remove ktx libraries #7106
remove ktx libraries #7106
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @VinayGuthal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on simplifying the project's build configuration by removing direct references to various Firebase Kotlin extension (KTX) libraries from the subprojects.cfg file. This change streamlines the list of subprojects, potentially indicating a shift in how these KTX modules are managed or integrated within the larger project structure.
Highlights
- Configuration Cleanup: Removed numerous explicit references to Firebase Kotlin extension (KTX) libraries from the
subprojects.cfgfile. This includes KTX modules for App Check, App Distribution, Common, Config, Crashlytics, Database, Dynamic Links, Firestore, Functions, Messaging, In-App Messaging, Installations, ML Model Downloader, Performance Monitoring, and Storage.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request aims to remove the KTX library modules from the project. While the change in subprojects.cfg correctly removes these modules from the build configuration, it's incomplete. There are numerous lingering dependencies on the removed KTX modules (especially firebase-common-ktx) in various build.gradle files across the repository. These will cause build failures. I've left a detailed comment on subprojects.cfg listing the files that need to be updated. Please address these issues to ensure the project's integrity.
|
Need to update the bom configuration |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Generated by 🚫 Danger |
plugins test results68 tests 68 ✅ 2m 5s ⏱️ Results for commit 04db9b0. ♻️ This comment has been updated with latest results. |
|
The public api surface has changed for the subproject firebase-ml-modeldownloader: The public api surface has changed for the subproject firebase-appdistribution-api: The public api surface has changed for the subproject firebase-database: The public api surface has changed for the subproject firebase-inappmessaging: The public api surface has changed for the subproject firebase-storage: The public api surface has changed for the subproject firebase-firestore: The public api surface has changed for the subproject firebase-messaging: The public api surface has changed for the subproject firebase-common: The public api surface has changed for the subproject firebase-installations: The public api surface has changed for the subproject firebase-config: The public api surface has changed for the subproject appcheck_firebase-appcheck: The public api surface has changed for the subproject firebase-crashlytics: The public api surface has changed for the subproject firebase-inappmessaging-display: The public api surface has changed for the subproject firebase-perf: The public api surface has changed for the subproject firebase-functions: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
1 similar comment
|
The public api surface has changed for the subproject firebase-ml-modeldownloader: The public api surface has changed for the subproject firebase-appdistribution-api: The public api surface has changed for the subproject firebase-database: The public api surface has changed for the subproject firebase-inappmessaging: The public api surface has changed for the subproject firebase-storage: The public api surface has changed for the subproject firebase-firestore: The public api surface has changed for the subproject firebase-messaging: The public api surface has changed for the subproject firebase-common: The public api surface has changed for the subproject firebase-installations: The public api surface has changed for the subproject firebase-config: The public api surface has changed for the subproject appcheck_firebase-appcheck: The public api surface has changed for the subproject firebase-crashlytics: The public api surface has changed for the subproject firebase-inappmessaging-display: The public api surface has changed for the subproject firebase-perf: The public api surface has changed for the subproject firebase-functions: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Test Results 945 files + 905 945 suites +905 32m 52s ⏱️ + 32m 7s For more details on these failures, see this check. Results for commit 04db9b0. ± Comparison against base commit b9aa68c. ♻️ This comment has been updated with latest results. |
Size Report 1Affected Products
Test Logs |
Coverage Report 1Affected Products
Test Logs |
|
The public api surface has changed for the subproject firebase-ml-modeldownloader: The public api surface has changed for the subproject firebase-appdistribution-api: The public api surface has changed for the subproject firebase-database: The public api surface has changed for the subproject firebase-inappmessaging: The public api surface has changed for the subproject firebase-storage: The public api surface has changed for the subproject firebase-firestore: The public api surface has changed for the subproject firebase-messaging: The public api surface has changed for the subproject firebase-common: The public api surface has changed for the subproject firebase-installations: The public api surface has changed for the subproject firebase-config: The public api surface has changed for the subproject appcheck_firebase-appcheck: The public api surface has changed for the subproject firebase-crashlytics: The public api surface has changed for the subproject firebase-inappmessaging-display: The public api surface has changed for the subproject firebase-perf: The public api surface has changed for the subproject firebase-functions: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
The public api surface has changed for the subproject firebase-ml-modeldownloader: The public api surface has changed for the subproject firebase-appdistribution-api: The public api surface has changed for the subproject firebase-database: The public api surface has changed for the subproject firebase-inappmessaging: The public api surface has changed for the subproject firebase-storage: The public api surface has changed for the subproject firebase-firestore: The public api surface has changed for the subproject firebase-messaging: The public api surface has changed for the subproject firebase-common: The public api surface has changed for the subproject firebase-installations: The public api surface has changed for the subproject firebase-config: The public api surface has changed for the subproject appcheck_firebase-appcheck: The public api surface has changed for the subproject firebase-crashlytics: The public api surface has changed for the subproject firebase-inappmessaging-display: The public api surface has changed for the subproject firebase-perf: The public api surface has changed for the subproject firebase-functions: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
1 similar comment
|
The public api surface has changed for the subproject firebase-ml-modeldownloader: The public api surface has changed for the subproject firebase-appdistribution-api: The public api surface has changed for the subproject firebase-database: The public api surface has changed for the subproject firebase-inappmessaging: The public api surface has changed for the subproject firebase-storage: The public api surface has changed for the subproject firebase-firestore: The public api surface has changed for the subproject firebase-messaging: The public api surface has changed for the subproject firebase-common: The public api surface has changed for the subproject firebase-installations: The public api surface has changed for the subproject firebase-config: The public api surface has changed for the subproject appcheck_firebase-appcheck: The public api surface has changed for the subproject firebase-crashlytics: The public api surface has changed for the subproject firebase-inappmessaging-display: The public api surface has changed for the subproject firebase-perf: The public api surface has changed for the subproject firebase-functions: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
This PR removes all the KTX libraries and the docs associated with them. KTX libraries were deprecated a long time ago and now we are removing these as a part of our breaking change release. --------- Co-authored-by: Rodrigo Lazo Paz <[email protected]> Co-authored-by: Rodrigo Lazo <[email protected]>
All ktx related functionality has been merged to the main libraries, and the KTX-only code removed. See #7106
All ktx related functionality has been merged to the main libraries, and the KTX-only code removed. See #7106
This PR removes all the KTX libraries and the docs associated with them. KTX libraries were deprecated a long time ago and now we are removing these as a part of our breaking change release.