Skip to content

Update C++ standard to C++17 #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Update C++ standard to C++17 #1763

wants to merge 2 commits into from

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Update CMAKE_CXX_STANDARD to 17, which applies to all platforms.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Running integration tests and packaging.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Jun 30, 2025
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Jun 30, 2025
Copy link

github-actions bot commented Jun 30, 2025

❌  Integration test FAILED

Requested by @jonsimantov on commit 174068f
Last updated: Tue Jul 1 15:57 PDT 2025
View integration test log & download artifacts

Failures Configs
firestore
(6 items)[BUILD] [ERROR] [Windows] [x64] [openssl]
[TEST] [ERROR] [Linux] [x64] [openssl]
[TEST] [FAILURE] [iOS] [macos] [1/2 ios_device: simulator_target]
(6 failed tests)  FirestoreTest.CanCreateMultipleFirestoreInstances
  FirestoreTest.CanKeepDocsSeparateWithMultiDBWhenOffline
  FirestoreTest.CanKeepDocsSeparateWithMultiDBWhenOnline
  FirestoreTest.CanReadDocsAfterRestartFirestoreAndCreateNewInstance
  FirestoreTest.CanTerminateMultipleFirestoreInstances
  FirestoreTest.ComprehensiveTestOnMultiDbCreationAndTermination
[TEST] [FAILURE] [iOS] [macos] [All 2 ios_device]
(171 failed tests)  ArrayTransformServerApplicationTest.MergeSetWithNoCachedBaseDoc
  ArrayTransformServerApplicationTest.SetWithNoCachedBaseDoc
  ArrayTransformServerApplicationTest.UpdateWithCachedBaseDocUsingArrayRemove
  ArrayTransformServerApplicationTest.UpdateWithCachedBaseDocUsingArrayUnion
  ArrayTransformTest.AppendObjectToArrayViaUpdate
  ArrayTransformTest.AppendToArrayViaMergeSet
  ArrayTransformTest.AppendToArrayViaUpdate
  ArrayTransformTest.CreateDocumentWithArrayUnion
  ArrayTransformTest.RemoveFromArrayViaMergeSet
  ArrayTransformTest.RemoveFromArrayViaUpdate
  ArrayTransformTest.RemoveObjectFromArrayViaUpdate
  BundleTest.CanLoadBundlesWithProgressUpdates
  BundleTest.CanLoadBundlesWithoutProgressUpdates
  BundleTest.LoadBundleWithDocumentsAlreadyPulledFromBackend
  BundleTest.LoadBundlesForASecondTimeSkips
  BundleTest.LoadedDocumentsShouldNotBeGarbageCollectedRightAway
  CleanupTest.FieldValueIsBlankAfterCleanup
  FieldsTest.TestFieldsWithSpecialCharsCanBeReadDirectly
  FieldsTest.TestFieldsWithSpecialCharsCanBeUpdated
  FieldsTest.TestFieldsWithSpecialCharsCanBeUsedInOrderBy
  FieldsTest.TestFieldsWithSpecialCharsCanBeUsedInQueryFilters
  FieldsTest.TestFieldsWithSpecialCharsCanBeWrittenWithSet
  FieldsTest.TestNestedFieldsCanBeReadDirectly
  FieldsTest.TestNestedFieldsCanBeReadDirectlyViaFieldPath
  FieldsTest.TestNestedFieldsCanBeUpdated
  FieldsTest.TestNestedFieldsCanBeUsedInOrderBy
  FieldsTest.TestNestedFieldsCanBeUsedInQueryFilters
  FieldsTest.TestNestedFieldsCanBeWrittenWithSet
  FieldsTest.TestTimestampsInSnapshots
  FilterTest.QueryEmptyWhereComposite
  FilterTest.QueryWhereComposite
  FirebaseFirestoreBasicTest.TestBatchWrite
  FirebaseFirestoreBasicTest.TestDocumentListener
  FirebaseFirestoreBasicTest.TestQuery
  FirebaseFirestoreBasicTest.TestRunTransaction
  FirebaseFirestoreBasicTest.TestSetGet
  FirebaseFirestoreBasicTest.TestSetUpdateGet
  FirestoreIntegrationTest.CanBeCreatedFromDocuments
  FirestoreIntegrationTest.CanBeCreatedFromValues
  FirestoreIntegrationTest.CanBeCreatedUsingDocumentId
  FirestoreIntegrationTest.CanBeUsedInDescendingQueries
  FirestoreIntegrationTest.CanBeUsedWithReferenceValues
  FirestoreIntegrationTest.CanPageThroughItems
  FirestoreTest.CanClearPersistenceTestHarnessVerification
  FirestoreTest.RestartFirestoreLeadsToNewInstance
  FirestoreTest.TestAddingToACollectionYieldsTheCorrectDocumentReference
  FirestoreTest.TestCanDeepMergeDataWithAnExistingDocumentUsingSet
  FirestoreTest.TestCanDeleteAFieldWithAnUpdate
  FirestoreTest.TestCanDeleteFieldUsingMerge
  FirestoreTest.TestCanDeleteFieldUsingMergeFields
  FirestoreTest.TestCanGetDocumentsWhileOffline
  FirestoreTest.TestCanMergeDataWithAnExistingDocumentUsingSet
  FirestoreTest.TestCanMergeEmptyObject
  FirestoreTest.TestCanMergeServerTimestamps
  FirestoreTest.TestCanOverwriteAnExistingDocumentUsingSet
  FirestoreTest.TestCanQueueWritesWhileOffline
  FirestoreTest.TestCanSetEmptyFieldMask
  FirestoreTest.TestCanSetServerTimestampsUsingMergeFields
  FirestoreTest.TestCanSpecifyFieldsMultipleTimesInFieldMask
  FirestoreTest.TestCanTraverseCollectionAndDocumentParents
  FirestoreTest.TestCanUpdateAnExistingDocument
  FirestoreTest.TestCanUpdateAnUnknownDocument
  FirestoreTest.TestCanUpdateFieldsWithDots
  FirestoreTest.TestCanUpdateFieldsWithMultipleDeletes
  FirestoreTest.TestCanUpdateNestedFields
  FirestoreTest.TestDeleteDocument
  FirestoreTest.TestDocumentReferenceEquality
  FirestoreTest.TestDocumentSnapshotEventsForAdd
  FirestoreTest.TestDocumentSnapshotEventsForChange
  FirestoreTest.TestDocumentSnapshotEventsForDelete
  FirestoreTest.TestFieldDeletesNotInFieldMaskAreIgnored
  FirestoreTest.TestFieldTransformsNotInFieldMaskAreIgnored
  FirestoreTest.TestFieldsNotInFieldMaskAreIgnored
  FirestoreTest.TestListenCanBeCalledMultipleTimes
  FirestoreTest.TestMergeReplacesArrays
  FirestoreTest.TestMetadataOnlyChangesAreNotFiredWhenNoOptionsProvided
  FirestoreTest.TestQuerySnapshotEventsForAdd
  FirestoreTest.TestQuerySnapshotEventsForChange
  FirestoreTest.TestQuerySnapshotEventsForDelete
  FirestoreTest.TestToString
  NumericTransformsTest.CreateDocumentWithIncrement
  NumericTransformsTest.DoubleIncrementWithExistingDouble
  NumericTransformsTest.DoubleIncrementWithExistingInteger
  NumericTransformsTest.DoubleIncrementWithExistingString
  NumericTransformsTest.IncrementDeleteIncrementInABatch
  NumericTransformsTest.IncrementTwiceInABatch
  NumericTransformsTest.IntegerIncrementWithExistingDouble
  NumericTransformsTest.IntegerIncrementWithExistingInteger
  NumericTransformsTest.IntegerIncrementWithExistingString
  NumericTransformsTest.MergeOnNonExistingDocumentWithIncrement
  NumericTransformsTest.MultipleDoubleIncrements
  NumericTransformsTest.ServerTimestampAndIncrement
  QueryNetworkTest.TestCanHaveMultipleMutationsWhileOffline
  QueryNetworkTest.TestQueriesFireFromCacheWhenOffline
  QueryTest.TestCanListenForTheSameQueryWithDifferentOptions
  QueryTest.TestFilterOnInfinity
  QueryTest.TestLimitQueries
  QueryTest.TestLimitQueriesUsingDescendingSortOrder
  QueryTest.TestListenUnlistenRelistenSequenceOfMirrorQueries
  QueryTest.TestQueriesCanUseArrayContainsAnyFilters
  QueryTest.TestQueriesCanUseArrayContainsFilters
  QueryTest.TestQueriesCanUseInFilters
  QueryTest.TestQueriesCanUseInFiltersWithDocIds
  QueryTest.TestQueriesCanUseNotEqualFilters
  QueryTest.TestQueriesCanUseNotEqualFiltersWithDocIds
  QueryTest.TestQueriesCanUseNotEqualFiltersWithNan
  QueryTest.TestQueriesCanUseNotEqualFiltersWithNull
  QueryTest.TestQueriesCanUseNotEqualFiltersWithObject
  QueryTest.TestQueriesCanUseNotInFilters
  QueryTest.TestQueriesCanUseNotInFiltersWithDocIds
  QueryTest.TestQueriesCanUseNotInFiltersWithNan
  QueryTest.TestQueriesCanUseNotInFiltersWithNanAndNumber
  QueryTest.TestQueriesCanUseNotInFiltersWithObject
  QueryTest.TestUnaryFilterQueries
  QueryTest.TestWillNotGetMetadataOnlyUpdates
  ServerTimestampTest.TestServerTimestampsCanRetainPreviousValueThroughConsecutiveUpdates
  ServerTimestampTest.TestServerTimestampsCanReturnEstimatedValue
  ServerTimestampTest.TestServerTimestampsCanReturnPreviousValue
  ServerTimestampTest.TestServerTimestampsCanReturnPreviousValueOfDifferentType
  ServerTimestampTest.TestServerTimestampsUsesPreviousValueFromLocalMutation
  ServerTimestampTest.TestServerTimestampsWorkViaSet
  ServerTimestampTest.TestServerTimestampsWorkViaTransactionSet
  ServerTimestampTest.TestServerTimestampsWorkViaTransactionUpdate
  ServerTimestampTest.TestServerTimestampsWorkViaUpdate
  SmokeTest.TestCanReadAWrittenDocument
  SmokeTest.TestGetCollectionQuery
  SmokeTest.TestObservesExistingDocument
  SmokeTest.TestObservesNewDocument
  SourceTest.GetCollectionWhileOfflineWithDefaultGetOptions
  SourceTest.GetCollectionWhileOfflineWithDifferentGetOptions
  SourceTest.GetCollectionWhileOfflineWithSourceEqualToCache
  SourceTest.GetCollectionWhileOnlineWithDefaultGetOptions
  SourceTest.GetCollectionWhileOnlineWithSourceEqualToCache
  SourceTest.GetCollectionWhileOnlineWithSourceEqualToServer
  SourceTest.GetDocumentWhileOfflineWithDefaultGetOptions
  SourceTest.GetDocumentWhileOfflineWithDifferentGetOptions
  SourceTest.GetDocumentWhileOfflineWithSourceEqualToCache
  SourceTest.GetDocumentWhileOnlineWithDefaultGetOptions
  SourceTest.GetDocumentWhileOnlineWithSourceEqualToCache
  SourceTest.GetDocumentWhileOnlineWithSourceEqualToServer
  TransactionExtraTest.TestRetriesWhenDocumentThatWasReadWithoutBeingWrittenChanges
  TransactionTest.TestCanHaveGetsWithoutMutations
  TransactionTest.TestGetNonexistentDocumentThenCreate
  TransactionTest.TestIncrementTransactionally
  TransactionTest.TestRunsTransactionsAfterGettingExistingDoc
  TransactionTest.TestRunsTransactionsAfterGettingNonexistentDoc
  TransactionTest.TestRunsTransactionsOnExistingDoc
  TransactionTest.TestRunsTransactionsOnNonexistentDoc
  TransactionTest.TestSetDocumentWithMerge
  TransactionTest.TestUpdateFieldsWithDotsTransactionally
  TransactionTest.TestUpdateNestedFieldsTransactionally
  TransactionTest.TestUpdateTransactionally
  TypeTest.TestCanReadAndWriteArrayFields
  TypeTest.TestCanReadAndWriteBlobFields
  TypeTest.TestCanReadAndWriteDateFields
  TypeTest.TestCanReadAndWriteDocumentReferences
  TypeTest.TestCanReadAndWriteDocumentReferencesInArrays
  TypeTest.TestCanReadAndWriteGeoPointFields
  TypeTest.TestCanReadAndWriteNullFields
  TypeTest.TestCanReadAndWriteTimestampFields
  ValidationTest.QueriesCannotBeCreatedFromDocumentsMissingSortValues
  ValidationTest.QueriesCannotBeSortedByAnUncommittedServerTimestamp
  WriteBatchTest.TestBatchesCommitAtomicallyRaisingCorrectEvents
  WriteBatchTest.TestBatchesFailAtomicallyRaisingCorrectEvents
  WriteBatchTest.TestCanWriteTheSameDocumentMultipleTimes
  WriteBatchTest.TestSetDocumentWithMerge
  WriteBatchTest.TestSetDocuments
  WriteBatchTest.TestUpdateDocuments
  WriteBatchTest.TestUpdateFieldsWithDots
  WriteBatchTest.TestUpdateNestedFields
  WriteBatchTest.TestWriteTheSameServerTimestampAcrossWrites
[TEST] [FAILURE] [tvOS] [macos] [tvos_simulator]
(172 failed tests)  ArrayTransformServerApplicationTest.MergeSetWithNoCachedBaseDoc
  ArrayTransformServerApplicationTest.SetWithNoCachedBaseDoc
  ArrayTransformServerApplicationTest.UpdateWithCachedBaseDocUsingArrayRemove
  ArrayTransformServerApplicationTest.UpdateWithCachedBaseDocUsingArrayUnion
  ArrayTransformTest.AppendObjectToArrayViaUpdate
  ArrayTransformTest.AppendToArrayViaMergeSet
  ArrayTransformTest.AppendToArrayViaUpdate
  ArrayTransformTest.CreateDocumentWithArrayUnion
  ArrayTransformTest.RemoveFromArrayViaMergeSet
  ArrayTransformTest.RemoveFromArrayViaUpdate
  ArrayTransformTest.RemoveObjectFromArrayViaUpdate
  CleanupTest.FieldValueIsBlankAfterCleanup
  FieldsTest.TestFieldsWithSpecialCharsCanBeReadDirectly
  FieldsTest.TestFieldsWithSpecialCharsCanBeUpdated
  FieldsTest.TestFieldsWithSpecialCharsCanBeUsedInOrderBy
  FieldsTest.TestFieldsWithSpecialCharsCanBeUsedInQueryFilters
  FieldsTest.TestFieldsWithSpecialCharsCanBeWrittenWithSet
  FieldsTest.TestNestedFieldsCanBeReadDirectly
  FieldsTest.TestNestedFieldsCanBeReadDirectlyViaFieldPath
  FieldsTest.TestNestedFieldsCanBeUpdated
  FieldsTest.TestNestedFieldsCanBeUsedInOrderBy
  FieldsTest.TestNestedFieldsCanBeUsedInQueryFilters
  FieldsTest.TestNestedFieldsCanBeWrittenWithSet
  FieldsTest.TestTimestampsInSnapshots
  FilterTest.QueryEmptyWhereComposite
  FilterTest.QueryWhereComposite
  FirebaseFirestoreBasicTest.TestBatchWrite
  FirebaseFirestoreBasicTest.TestDocumentListener
  FirebaseFirestoreBasicTest.TestQuery
  FirebaseFirestoreBasicTest.TestRunTransaction
  FirebaseFirestoreBasicTest.TestSetGet
  FirebaseFirestoreBasicTest.TestSetUpdateGet
  FirestoreIntegrationTest.CanBeCreatedFromDocuments
  FirestoreIntegrationTest.CanBeCreatedFromValues
  FirestoreIntegrationTest.CanBeCreatedUsingDocumentId
  FirestoreIntegrationTest.CanBeUsedInDescendingQueries
  FirestoreIntegrationTest.CanBeUsedWithReferenceValues
  FirestoreIntegrationTest.CanPageThroughItems
  FirestoreTest.CanClearPersistenceTestHarnessVerification
  FirestoreTest.CanCreateMultipleFirestoreInstances
  FirestoreTest.CanKeepDocsSeparateWithMultiDBWhenOffline
  FirestoreTest.CanKeepDocsSeparateWithMultiDBWhenOnline
  FirestoreTest.CanReadDocsAfterRestartFirestoreAndCreateNewInstance
  FirestoreTest.CanTerminateMultipleFirestoreInstances
  FirestoreTest.ComprehensiveTestOnMultiDbCreationAndTermination
  FirestoreTest.RestartFirestoreLeadsToNewInstance
  FirestoreTest.TestAddingToACollectionYieldsTheCorrectDocumentReference
  FirestoreTest.TestCanDeepMergeDataWithAnExistingDocumentUsingSet
  FirestoreTest.TestCanDeleteAFieldWithAnUpdate
  FirestoreTest.TestCanDeleteFieldUsingMerge
  FirestoreTest.TestCanDeleteFieldUsingMergeFields
  FirestoreTest.TestCanGetDocumentsWhileOffline
  FirestoreTest.TestCanMergeDataWithAnExistingDocumentUsingSet
  FirestoreTest.TestCanMergeEmptyObject
  FirestoreTest.TestCanMergeServerTimestamps
  FirestoreTest.TestCanOverwriteAnExistingDocumentUsingSet
  FirestoreTest.TestCanQueueWritesWhileOffline
  FirestoreTest.TestCanSetEmptyFieldMask
  FirestoreTest.TestCanSetServerTimestampsUsingMergeFields
  FirestoreTest.TestCanSpecifyFieldsMultipleTimesInFieldMask
  FirestoreTest.TestCanTraverseCollectionAndDocumentParents
  FirestoreTest.TestCanUpdateAnExistingDocument
  FirestoreTest.TestCanUpdateAnUnknownDocument
  FirestoreTest.TestCanUpdateFieldsWithDots
  FirestoreTest.TestCanUpdateFieldsWithMultipleDeletes
  FirestoreTest.TestCanUpdateNestedFields
  FirestoreTest.TestDeleteDocument
  FirestoreTest.TestDocumentReferenceEquality
  FirestoreTest.TestDocumentSnapshotEventsForAdd
  FirestoreTest.TestDocumentSnapshotEventsForChange
  FirestoreTest.TestDocumentSnapshotEventsForDelete
  FirestoreTest.TestFieldDeletesNotInFieldMaskAreIgnored
  FirestoreTest.TestFieldTransformsNotInFieldMaskAreIgnored
  FirestoreTest.TestFieldsNotInFieldMaskAreIgnored
  FirestoreTest.TestListenCanBeCalledMultipleTimes
  FirestoreTest.TestMergeReplacesArrays
  FirestoreTest.TestMetadataOnlyChangesAreNotFiredWhenNoOptionsProvided
  FirestoreTest.TestQuerySnapshotEventsForAdd
  FirestoreTest.TestQuerySnapshotEventsForChange
  FirestoreTest.TestQuerySnapshotEventsForDelete
  FirestoreTest.TestToString
  NumericTransformsTest.CreateDocumentWithIncrement
  NumericTransformsTest.DoubleIncrementWithExistingDouble
  NumericTransformsTest.DoubleIncrementWithExistingInteger
  NumericTransformsTest.DoubleIncrementWithExistingString
  NumericTransformsTest.IncrementDeleteIncrementInABatch
  NumericTransformsTest.IncrementTwiceInABatch
  NumericTransformsTest.IntegerIncrementWithExistingDouble
  NumericTransformsTest.IntegerIncrementWithExistingInteger
  NumericTransformsTest.IntegerIncrementWithExistingString
  NumericTransformsTest.MergeOnNonExistingDocumentWithIncrement
  NumericTransformsTest.MultipleDoubleIncrements
  NumericTransformsTest.ServerTimestampAndIncrement
  QueryNetworkTest.TestCanHaveMultipleMutationsWhileOffline
  QueryNetworkTest.TestQueriesFireFromCacheWhenOffline
  QueryTest.TestCanListenForTheSameQueryWithDifferentOptions
  QueryTest.TestFilterOnInfinity
  QueryTest.TestLimitQueries
  QueryTest.TestLimitQueriesUsingDescendingSortOrder
  QueryTest.TestListenUnlistenRelistenSequenceOfMirrorQueries
  QueryTest.TestQueriesCanUseArrayContainsAnyFilters
  QueryTest.TestQueriesCanUseArrayContainsFilters
  QueryTest.TestQueriesCanUseInFilters
  QueryTest.TestQueriesCanUseInFiltersWithDocIds
  QueryTest.TestQueriesCanUseNotEqualFilters
  QueryTest.TestQueriesCanUseNotEqualFiltersWithDocIds
  QueryTest.TestQueriesCanUseNotEqualFiltersWithNan
  QueryTest.TestQueriesCanUseNotEqualFiltersWithNull
  QueryTest.TestQueriesCanUseNotEqualFiltersWithObject
  QueryTest.TestQueriesCanUseNotInFilters
  QueryTest.TestQueriesCanUseNotInFiltersWithDocIds
  QueryTest.TestQueriesCanUseNotInFiltersWithNan
  QueryTest.TestQueriesCanUseNotInFiltersWithNanAndNumber
  QueryTest.TestQueriesCanUseNotInFiltersWithObject
  QueryTest.TestUnaryFilterQueries
  QueryTest.TestWillNotGetMetadataOnlyUpdates
  ServerTimestampTest.TestServerTimestampsCanRetainPreviousValueThroughConsecutiveUpdates
  ServerTimestampTest.TestServerTimestampsCanReturnEstimatedValue
  ServerTimestampTest.TestServerTimestampsCanReturnPreviousValue
  ServerTimestampTest.TestServerTimestampsCanReturnPreviousValueOfDifferentType
  ServerTimestampTest.TestServerTimestampsUsesPreviousValueFromLocalMutation
  ServerTimestampTest.TestServerTimestampsWorkViaSet
  ServerTimestampTest.TestServerTimestampsWorkViaTransactionSet
  ServerTimestampTest.TestServerTimestampsWorkViaTransactionUpdate
  ServerTimestampTest.TestServerTimestampsWorkViaUpdate
  SmokeTest.TestCanReadAWrittenDocument
  SmokeTest.TestGetCollectionQuery
  SmokeTest.TestObservesExistingDocument
  SmokeTest.TestObservesNewDocument
  SourceTest.GetCollectionWhileOfflineWithDefaultGetOptions
  SourceTest.GetCollectionWhileOfflineWithDifferentGetOptions
  SourceTest.GetCollectionWhileOfflineWithSourceEqualToCache
  SourceTest.GetCollectionWhileOnlineWithDefaultGetOptions
  SourceTest.GetCollectionWhileOnlineWithSourceEqualToCache
  SourceTest.GetCollectionWhileOnlineWithSourceEqualToServer
  SourceTest.GetDocumentWhileOfflineWithDefaultGetOptions
  SourceTest.GetDocumentWhileOfflineWithDifferentGetOptions
  SourceTest.GetDocumentWhileOfflineWithSourceEqualToCache
  SourceTest.GetDocumentWhileOnlineWithDefaultGetOptions
  SourceTest.GetDocumentWhileOnlineWithSourceEqualToCache
  SourceTest.GetDocumentWhileOnlineWithSourceEqualToServer
  TransactionExtraTest.TestRetriesWhenDocumentThatWasReadWithoutBeingWrittenChanges
  TransactionTest.TestCanHaveGetsWithoutMutations
  TransactionTest.TestGetNonexistentDocumentThenCreate
  TransactionTest.TestIncrementTransactionally
  TransactionTest.TestRunsTransactionsAfterGettingExistingDoc
  TransactionTest.TestRunsTransactionsAfterGettingNonexistentDoc
  TransactionTest.TestRunsTransactionsOnExistingDoc
  TransactionTest.TestRunsTransactionsOnNonexistentDoc
  TransactionTest.TestSetDocumentWithMerge
  TransactionTest.TestUpdateFieldsWithDotsTransactionally
  TransactionTest.TestUpdateNestedFieldsTransactionally
  TransactionTest.TestUpdateTransactionally
  TypeTest.TestCanReadAndWriteArrayFields
  TypeTest.TestCanReadAndWriteBlobFields
  TypeTest.TestCanReadAndWriteDateFields
  TypeTest.TestCanReadAndWriteDocumentReferences
  TypeTest.TestCanReadAndWriteDocumentReferencesInArrays
  TypeTest.TestCanReadAndWriteGeoPointFields
  TypeTest.TestCanReadAndWriteNullFields
  TypeTest.TestCanReadAndWriteTimestampFields
  ValidationTest.QueriesCannotBeCreatedFromDocumentsMissingSortValues
  ValidationTest.QueriesCannotBeSortedByAnUncommittedServerTimestamp
  WriteBatchTest.TestBatchesCommitAtomicallyRaisingCorrectEvents
  WriteBatchTest.TestBatchesFailAtomicallyRaisingCorrectEvents
  WriteBatchTest.TestCanWriteTheSameDocumentMultipleTimes
  WriteBatchTest.TestSetDocumentWithMerge
  WriteBatchTest.TestSetDocuments
  WriteBatchTest.TestUpdateDocuments
  WriteBatchTest.TestUpdateFieldsWithDots
  WriteBatchTest.TestUpdateNestedFields
  WriteBatchTest.TestWriteTheSameServerTimestampAcrossWrites
[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  FirestoreTest.TestQuerySnapshotEventsForChange

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jun 30, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 30, 2025
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jul 1, 2025
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Jul 1, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants