Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Config] Follow-up to 'RCNRealtime' port #14303

Merged
merged 5 commits into from
Jan 4, 2025
Merged

[Config] Follow-up to 'RCNRealtime' port #14303

merged 5 commits into from
Jan 4, 2025

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jan 3, 2025 •
edited
Loading

#no-changelog

@ncooke3 ncooke3 marked this pull request as ready for review January 3, 2025 22:10
@ncooke3 ncooke3 requested a review from paulb777 January 3, 2025 22:10
paulb777
paulb777 approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after comments addressed. Thanks!

@ncooke3 ncooke3 merged commit b79b6d8 into rc-swift Jan 4, 2025
28 of 32 checks passed
@ncooke3 ncooke3 deleted the nc/realtime branch January 4, 2025 00:08
paulb777 pushed a commit that referenced this pull request Jan 17, 2025
@ncooke3 @paulb777
[Config] Follow-up to 'RCNRealtime' port (#14303)
2c61afb
@firebase firebase locked and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: remoteconfig
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncooke3 @paulb777 @google-oss-bot