Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise testing and CI #209

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

JHopeCollins
Copy link
Member

@JHopeCollins JHopeCollins commented Nov 22, 2024

Bit of a reorganisation of the testing and CI.

Testing changes:

  1. Split into unit tests and integration tests. Unit tests shouldn't depend on any other module, and the integration tests require multiple.
  2. The tests using CirculantPC with the AllAtOnceSolver have been removed from tests/units/allatonce - this means that the tests in tests/unit/allatonce doesn't depend on complex_proxy. The removed tests have been added to tests/integration

CI changes:

  1. Automatically open PRs to update github actions with dependabot.yml, e.g. action/checkout@v2 is two versions out of date.
  2. Automatically run the CI tests over the weekend with a cron job to see if any upstream changes have broken things for us
  3. In the CI workflow, run the unit tests, then the integration tests. If any of the unit tests fail then the integration tests will almost certainly fail, so this stops them running unnecessarily. The pytest-coverage is cumulative over both runs so the coverage report at the end should be accurate.

Note that the tests won't pass until the Firedrake docker has rebuilt after firedrakeproject/firedrake#3895 merged into Firedrake master. This is now finished.

Automatically open PRs to update github actions
@JHopeCollins JHopeCollins added the tests unit or integration tests label Nov 22, 2024
@JHopeCollins JHopeCollins self-assigned this Nov 22, 2024
@JHopeCollins JHopeCollins changed the title Create dependabot.yml Reorganise testing and CI Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests unit or integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant