-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AllAtOnceReducedFunctional
- initial time-parallel implementation
#3870
Draft
JHopeCollins
wants to merge
22
commits into
allatoncereducedfunctional
Choose a base branch
from
JHopeCollins/aaorf_timeparallel
base: allatoncereducedfunctional
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
AllAtOnceReducedFunctional
- initial time-parallel implementation
#3870
JHopeCollins
wants to merge
22
commits into
allatoncereducedfunctional
from
JHopeCollins/aaorf_timeparallel
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linting was failing.
* Add adjoint variational solver.
--------- Co-authored-by: Aaron Baier-Reinio <[email protected]>
* Simplify fwi test when run under CI
* Fix progress bar erros for parallel executions * Test for a parallel execution
* Add petsc_raises fixture to catch PETSc callback exceptions
* Fix assembly of Real matrices
* Refactor test_demos, avoid mpiexec invocation * Fix multigrid test, __main__ is not valid when importing
* Get value_shape from FunctionSpace * Define FunctionSpace.block_size as the number of dofs per node * sort_domains --------- Co-authored-by: ksagiyam <[email protected]>
- observation stages distributed over ensemble - context manager for recording the forward model and passing data between stages - iterator to record each stage and set the observation
|
@JHopeCollins FYI I broke one of the runners today. Hence the failure. I will try and fix it tomorrow. |
|
No problem. I think I also need to merge main to update the versions of some of the stuff in CI. |
* DO NOT MERGE * Test VOM with point variant * Update .github/workflows/build.yml * Test Regge point variant * add continuity test * Test H(curl div) element (#3843) * Test H(curl div) element * test Hu-Zhang * checkout ufl master branch * checkout master branches
JHopeCollins
commented
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To merge into #3592
Parallelism implementation:
Context manager+iterator for taping each stage:
https://github.com/firedrakeproject/4DVardrake/blob/2417d7cdff4a0a159ae8dcc9e12fb90d2382a67c/burgers/aaorf_4dvar_parallel.py#L250