Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/responsive navigation #467

Open
wants to merge 3 commits into
base: source
Choose a base branch
from
Open

Fix/responsive navigation #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
452d709
fix: remove unused class
tonkec Dec 17, 2024
7e754dd
fix: make navbar responsive
tonkec Dec 17, 2024
d0bd908
fix: remove slack since link is no longer active
tonkec Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 38 additions & 36 deletions src/components/Navbar/Navbar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,51 +1,53 @@
.topnav {
background-color: #1f293726;
overflow: hidden;
text-align: right;
backdrop-filter: blur(16px);
border: 1px solid #f9fafb1a;
padding: 1.1rem;
display: flex;
justify-content:flex-end;
gap: 16px;
background-color: #1f293726;
overflow: hidden;
text-align: right;
backdrop-filter: blur(16px);
border: 1px solid #f9fafb1a;
padding: 1.1rem;
display: flex;
justify-content: flex-end;
gap: 16px;
}

@media (max-width: 700px) {
.topnav {
text-align: center;
overflow: auto;
justify-content: flex-start;
}
.topnav {
flex-direction: column;
text-align: center;
overflow: auto;
justify-content: flex-start;
}
}

.topnav a {
display: flex;
align-items: center;
gap: 8px;
color: #f2f2f2;
text-align: center;
padding: 0px 15px;
text-decoration: none;
border: 1px solid transparent;
/* font-size: 20px; */
display: flex;
align-items: center;
gap: 8px;
color: #f2f2f2;
text-align: center;
padding: 0px 15px;
text-decoration: none;
border: 1px solid transparent;
/* font-size: 20px; */
}

.topnav a:hover {
background-color: #2c2e2fb3;
color: #f2f2f2;
border-radius: 12px;
border:1px solid #b6b6b94a;
/* display: inline; */
background-color: #2c2e2fb3;
color: #f2f2f2;
border-radius: 12px;
border: 1px solid #b6b6b94a;
/* display: inline; */
}

.topnav a.active {
background-color: #4CAF50;
color: white;
background-color: #4caf50;
color: white;
}

.logo{
margin-top: 10px;
width: 52px;
vertical-align:middle;
height: 42px;
display: inline-block;
.logo {
margin-top: 10px;
width: 52px;
vertical-align: middle;
height: 42px;
display: inline-block;
}
5 changes: 0 additions & 5 deletions src/components/Navbar/Navbar.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,12 @@
import React from 'react';
import './Navbar.css';
import slack from './slack.svg';
import youtube from './youtube.svg';
import twitter from './twitter.svg';
import github from './github.svg';

const Navbar = () => {
return (
<div className="topnav">
<a href="https://join.slack.com/t/firstcontributors/shared_invite/zt-1n4y7xnk0-DnLVTaN6U9xLU79H5Hi62w" target="_blank" rel="noopener noreferrer">
<img src={slack} className="logo" alt="slack logo" />
<span>Slack</span>
</a>
<a href="https://www.youtube.com/channel/UCMXNFxCvyH5LhUwEcmY8qGQ" target="_blank" rel="noopener noreferrer">
<img src={youtube} className="logo" alt="youtube logo" />
<span>Youtube</span>
Expand Down
1 change: 0 additions & 1 deletion src/components/Navbar/slack.svg
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/components/ProjectList/CardsContainer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ export default class CardsContainer extends React.Component {
projectLink={item.projectLink}
description={item.description}
tags={item.tags}
className='testing-testing'
/>
);
})}
Expand Down