Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XS_Kerrconv model to convolutional.jl #128

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

GloriaRAH
Copy link
Contributor

@GloriaRAH GloriaRAH commented Sep 30, 2024

Adding a new convolutional model XS_Kerrconv

@fjebaker
Copy link
Owner

Test failing is not your fault

multifits: Error During Test at /home/runner/work/SpectralFitting.jl/SpectralFitting.jl/test/runtests.jl:96
  Got exception outside of a @test
  LoadError: MissingBackendError: Failed to use AutoReverseDiff().
  Backend package is probably not loaded. To fix this, try to run
  
      import ReverseDiff
  
  Stacktrace:

I will investigate this shortly.

@fjebaker
Copy link
Owner

Tested with

using SpectralFitting, Plots
model = XS_Kerrconv()
es = collect(range(0.1, 10.0, 200))
fs = allocate_model_output(model, es)
fs[100] = 1
plot(es[1:end-1], invokemodel!(fs, es, model))

image

Works fine!

@fjebaker
Copy link
Owner

I will merge this and then try and find out why the test suite is broken.

@fjebaker fjebaker merged commit e1aca7b into fjebaker:main Sep 30, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants