feat: Support for Web #48
Open
+236
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/gamepads_web/pubspec.yaml
Outdated
| flutter_web_plugins: | ||
| sdk: flutter | ||
| gamepads_platform_interface: ^0.1.2+1 | ||
| js: ^0.6.3 |
There was a problem hiding this comment.
I believe that the dart:js package is deprecated: https://dart.dev/interop/js-interop
There was a problem hiding this comment.
Thanks for reminding! I have updated to use js_interop and package:web instead of package:js and dart:html.
spydon
reviewed
Oct 24, 2024
Comment on lines
57
to
64
| final gamepads = navigator.getGamepads(); | ||
| return List.generate(gamepads.length, (i) { | ||
| final gamepad = gamepads[i]; | ||
| if (gamepad != null) { | ||
| return gamepad; | ||
| } | ||
| return null; | ||
| }).where((gamepad) => gamepad != null).toList(); |
There was a problem hiding this comment.
Suggested change
| final gamepads = navigator.getGamepads(); | |
| return List.generate(gamepads.length, (i) { | |
| final gamepad = gamepads[i]; | |
| if (gamepad != null) { | |
| return gamepad; | |
| } | |
| return null; | |
| }).where((gamepad) => gamepad != null).toList(); | |
| return navigator.getGamepads().toDart.whereNotNull(); |
Shouldn't this be enough?
There was a problem hiding this comment.
I did't notice that I can use gamepad in package:web. Updated the implementation.
| return controllers; | ||
| } | ||
|
|
||
| List<dynamic> getGamepadList() { |
There was a problem hiding this comment.
I did't get it well. Does the latest implementation look fine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am developing an app requiring web support for gamepads. I would like to contribute to this project. Please help review this pull request. Thanks!