Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addon-operator] fix nil, add error handling, fix logger #566

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

ldmonster
Copy link
Contributor

Overview

After we return nil helm module, we must not to use render (because of nil).
Added new error and handle it, where it needs

Inside touched files:
Add errors wrapping
Replace global logger with local logger

What this PR does / why we need it

Special notes for your reviewer

@ldmonster ldmonster added the enhancement New feature or request label Mar 4, 2025
@ldmonster ldmonster self-assigned this Mar 4, 2025
@ldmonster ldmonster requested review from miklezzzz and yalosev March 4, 2025 09:26
Copy link
Contributor

@miklezzzz miklezzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a good catch, though I would do something with double error checking around RunHelmInstall, looks pretty ugly :(

@yalosev yalosev merged commit 56e9934 into main Mar 6, 2025
8 checks passed
@yalosev yalosev deleted the fix/helm-module-nil branch March 6, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants