-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: local -> external builder mapping #47
Conversation
@avalonche can you pls check if the logic makes sense?
|
thanks for the PR! will review soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it'll be great if you can add some tests asserting when
- payload ids are the same
- payload ids are different
and check that the correct payload id is used.
Also there seems to be lint issues
Thanks for the review @avalonche . Addressed it! |
I've fixed some failing tests here |
Thanks! I see it was about running the tests sequentially. Personally not a fan of having all of them under |
Overview
This PR adds payload ID mapping functionality to track and map between local and external payload IDs when interacting with the builder node. This ensures proper correlation between payloads across different nodes.
Key changes:
local_to_external_payload_ids
cache toPayloadTraceContext
to store mappingsget_payload_v3
to use external payload ID when requesting from builderfork_choice_updated_v3
response handlingThe changes help maintain proper tracing and correlation between local execution engine payloads and external builder payloads, improving debuggability and reliability of the system.
fixes #46