Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/precommit issues #931

Merged
merged 5 commits into from
Mar 12, 2025
Merged

Conversation

diptorupd
Copy link
Contributor

  • The PR applies missing pre-commit identified formatting fixes to the CUDA headers inside include.
  • Also adds a github action workflow against PRs to enforce pre-commit checks.

Copy link
Collaborator

@yzh119 yzh119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@diptorupd
Copy link
Contributor Author

@yzh119 Thanks for approving the changes and sorry about the typo in the workflow. I was under the impression that the workflow will only catch new changes. It seems it has identified all existing issues. Do you want me to add a commit fixing all files that got flagged by pre-commit?

@diptorupd
Copy link
Contributor Author

Do you want me to add a commit fixing all files that got flagged by pre-commit?

I added two other commits that fix the rest of the sources.

@diptorupd diptorupd requested a review from yzh119 March 12, 2025 16:13
@yzh119 yzh119 merged commit 8d29762 into flashinfer-ai:main Mar 12, 2025
1 check passed
@diptorupd diptorupd deleted the fix/precommit-issues branch March 12, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants