Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] for-team-members: add info on what they are and how to become one #317

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pabloyoyoista
Copy link

This is written from an external contributor point on view, as we discussed this during FOSDEM that you could get help with a process to get people onboarded into the team. I come from a bit of a different background, so might totally be that this is not what you want, and I'm very happy to iterate or help you do it.

I think one thing missing would be to list the current team members somewhere, but certainly I do not know which place should that be. Also, are there any other benefits you get from being a team member? In postmarketOS we give people an inbox, for example, but that's also because it's sort of needed. Just wondering because some of those small things sometimes motivate people when they're already thinking about it.

@bbhtt
Copy link
Contributor

bbhtt commented May 6, 2024

would be to list the current team members somewhere

Probably the team docs sounds fine.

Also, are there any other benefits you get from being a team member?

Nope just GitHub access depending on which Github team they are added to and access to Flathub.org moderation (quality, permission etc.).

In consequence, they can be seen as the auditors and moderators of our
community. As such, they play a big role in the decision-making process.
They are also an important part of the Flathub and Flatpak trust model. The fact
that applications permissions are audited by the community is a warranty to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
that applications permissions are audited by the community is a warranty to
that application's permissions are audited by the community is a warranty to

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"by the community" - maybe "by the moderators"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's up to you if you want to use one or the other. Applied the suggestion, but keep this open for the community/moderators discussion

docs/03-for-team-members/02-becoming-a-team-member.md Outdated Show resolved Hide resolved
## Becoming a team member

Since auditing apps and permissions is a great task, we are always in need of
more hands. If you want to be part of our team, help out and enjoy the benefits,
Copy link
Contributor

@bbhtt bbhtt May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are not many "benefits" so as to speak of #317 (comment)

docs/03-for-team-members/02-becoming-a-team-member.md Outdated Show resolved Hide resolved
Comment on lines +34 to +35
* Review current apps to request and update permissions access.
TODO: Is there a public place where this is done that people can contribute
to? Or maybe just look at some existing apps?
Copy link
Contributor

@bbhtt bbhtt May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going from repo to repo right now and there is no easy way to figure out what to report unless you are a user of the app and notice something.

A better thing to add would be just contributing in general: doing runtime updates, contributing to infra related repos, doing app updates, anything.

I'd avoid making the process too complicated.

docs/03-for-team-members/02-becoming-a-team-member.md Outdated Show resolved Hide resolved
@pabloyoyoista
Copy link
Author

Pushed most of the comments, left open those that probably need more feedback or are in the TODOs

docs/03-for-team-members/02-becoming-a-team-member.md Outdated Show resolved Hide resolved
docs/03-for-team-members/02-becoming-a-team-member.md Outdated Show resolved Hide resolved
docs/03-for-team-members/02-becoming-a-team-member.md Outdated Show resolved Hide resolved
docs/03-for-team-members/02-becoming-a-team-member.md Outdated Show resolved Hide resolved
docs/03-for-team-members/02-becoming-a-team-member.md Outdated Show resolved Hide resolved
TODO: For how long should have people contributed? How many apps should they
have reviewed?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not putting any limit is better. The current team can decide on case by case basis.

to? Or maybe just look at some existing apps?
* Open an issue in the [flathub](https://github.com/flathub/flathub/) repo,
listing your contributions and why you want you become a member.
TODO: Maybe in the flathub repo? An issue template could help?
Copy link
Contributor

@bbhtt bbhtt May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First todo seems done. Just needs the issue template if we decide on that. We aren't that big on having issue templates but I don't mind either way.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the first TODO

@pabloyoyoista
Copy link
Author

Applied all suggestions regarding the wording, kept those related to TODOs as I guess you need to discuss that among yourselves and not with me :D

And if I didn't say it before, thanks a lot for the reviews! Certainly my writing style is not the best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants