Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verify fleetd-base files > verify-fleetd-base-msi powershell script #25064

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

jacobshandling
Copy link
Contributor

@jacobshandling jacobshandling commented Dec 31, 2024

See failed workflow run here

  • Fix the powershell script that was broken by .yml auto-format

  • Exclude github workflow .yml files from prettier autoformating, since they often contain non-yaml code as part of job definitions

  • Manual QA for all new/changed functionality

Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sharon-fdm sharon-fdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobshandling jacobshandling merged commit 120f01a into main Jan 2, 2025
3 checks passed
jacobshandling added a commit that referenced this pull request Jan 2, 2025
…pt (#25064)

See failed workflow run
[here](https://github.com/fleetdm/fleet/actions/runs/12555703803)

- Fix the powershell script that was broken by `.yml` auto-format
- Exclude github workflow `.yml` files from prettier autoformating,
since they often contain non-yaml code as part of job definitions

- [ ] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <[email protected]>
@jacobshandling jacobshandling deleted the update-workflow branch January 2, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants