Unified Queue: implement correct fleet-initiated flag and setup experience priority #25448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
mna-23913-23918-unified-queue-3
to
feat-upcoming-activites-queue
January 15, 2025 17:53
mna
force-pushed
the
mna-23914-cleanup-fleet-initiated-and-priority-4
branch
from
5c718c0 to
9426701
Compare
…leet-initiated-and-priority-4
getvictor
approved these changes
Jan 17, 2025
| @@ -812,40 +812,45 @@ VALUES | |||
| return "", ctxerr.Wrap(ctx, err, "getting installer data") | |||
| } | |||
|
|
|||
| fleetInitiated := !opts.SelfService && opts.PolicyID != nil | |||
There was a problem hiding this comment.
nit: I would refactor this into: opts.IsFleetInitiated() and inline that call into line 833.
| @@ -812,40 +812,45 @@ VALUES | |||
| return "", ctxerr.Wrap(ctx, err, "getting installer data") | |||
| } | |||
|
|
|||
| fleetInitiated := !opts.SelfService && opts.PolicyID != nil | |||
| var priority int | |||
| if opts.ForSetupExperience { | |||
There was a problem hiding this comment.
nit: refactor into opts.Priority()?
Comment on lines
+604
to
+610
| fleetInitiated := !opts.SelfService && opts.PolicyID != nil | ||
| var priority int | ||
| if opts.ForSetupExperience { | ||
| // a bit naive/simplistic for now, but we'll support user-provided | ||
| // priorities in a future story and we can improve on how we manage those. | ||
| priority = 100 | ||
| } |
There was a problem hiding this comment.
Code duplication. See above comments.
gillespi314
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#23914
Checklist for submitter
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)