-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI – Updates to confirm invite flow #25583
Conversation
- Remove dependence on url params other than token - Spinner while using token to check server for invite validity - Use returned data with valid invites - Refactor JS –> TS - Refactor class –> functional components - Clean up
@@ -0,0 +1,38 @@ | |||
import { size } from "lodash"; | |||
import validateEquality from "components/forms/validators/validate_equality"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just calls lodash's isEqual
. Using here for consistency but perhaps we can retire this function in favor of calling the lodash method directly.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25583 +/- ##
==========================================
- Coverage 63.60% 63.55% -0.06%
==========================================
Files 1624 1621 -3
Lines 155419 154818 -601
Branches 3967 4023 +56
==========================================
- Hits 98856 98387 -469
+ Misses 48761 48670 -91
+ Partials 7802 7761 -41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, tested 👍
One suggestion would be to add a retry function to the useQuery
invocation. Right now it sits there spinning and retries four times even when the API response is a 404 -- it'd be better to have it show "invalid form" immediately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we not use the issue number only as the branch name. git gets confused when I try to switch to this branch cause it thinks I'm trying to check out a commit.
8ceca36
For #24486
Invalid invite
Valid invite
changes/