Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI – Add on-hover shadow and on row click functionality to script list items #25995

Merged
merged 10 commits into from
Feb 4, 2025
Merged

UI – Add on-hover shadow and on row click functionality to script list items #25995

merged 10 commits into from
Feb 4, 2025

Conversation

jacobshandling
Copy link
Contributor

For #24341

ezgif-7ab94d885a7bc

  • Changes file added for user-visible changes in `changes/
  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality

@jacobshandling jacobshandling requested a review from a team as a code owner February 3, 2025 21:00
@codecov Codecov
Copy link

codecov bot commented Feb 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.65%. Comparing base (de58010) to head (e80e646).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...ripts/components/ScriptListItem/ScriptListItem.tsx 81.81% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #25995   +/-   ##
=======================================
  Coverage   63.65%   63.65%           
=======================================
  Files        1631     1631           
  Lines      156250   156256    +6     
  Branches     4027     4027           
=======================================
+ Hits        99454    99459    +5     
- Misses      48958    48959    +1     
  Partials     7838     7838
Flag Coverage Δ
frontend 53.42% <81.81%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobshandling jacobshandling force-pushed the 24341-mimic-custom-settings-list-UI-on-scripts-list branch from b0acbe3 to 5603d92 Compare February 3, 2025 22:31
@jacobshandling jacobshandling force-pushed the 24341-mimic-custom-settings-list-UI-on-scripts-list branch from 5603d92 to 035f9bb Compare February 3, 2025 22:38
jacobshandling
jacobshandling commented Feb 4, 2025
View reviewed changes
frontend/pages/ManageControlsPage/Scripts/components/ScriptListItem/ScriptListItem.tsx
@@ -80,15 +80,16 @@ const ScriptListItem = ({

const { graphicName, platform } = getFileRenderDetails(script.name);

const onClickEdit = (evt: React.MouseEvent | React.KeyboardEvent) => {
evt.stopPropagation();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensures that clicking the edit icon opens the edit script modal instead of script details modal, while preserving the latter functionality when clicking anywhere else in the script list item.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for other 2 action handlers

ghernandez345
ghernandez345 approved these changes Feb 4, 2025
View reviewed changes
frontend/pages/ManageControlsPage/Scripts/components/ScriptListItem/ScriptListItem.tests.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice tests on this file

...eControlsPage/OSSettings/cards/CustomSettings/components/ProfileListItem/ProfileListItem.tsx
@@ -119,6 +119,7 @@ const ProfileListItem = ({
};

return (
// TODO - refactor to use ListItem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Id agree. would be good to do this at some point.

sgress454
sgress454 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@sgress454 sgress454 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested 👍

@jacobshandling jacobshandling merged commit 53afcec into main Feb 4, 2025
14 checks passed
@jacobshandling jacobshandling deleted the 24341-mimic-custom-settings-list-UI-on-scripts-list branch February 4, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgress454 sgress454 sgress454 approved these changes

@ghernandez345 ghernandez345 ghernandez345 approved these changes

Assignees

@sgress454 sgress454

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobshandling @sgress454 @ghernandez345