-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diff 4.62.3 to 4.63.0 #26004
Diff 4.62.3 to 4.63.0 #26004
Conversation
For #24720. Used https://github.com/ChaelChu/msi-props-reader/blob/master/src/msiPropsReader.ts as inspiration. Not sure why the shift is 17 bits rather than 16 here but confirmed that 17 works and 16 doesn't. Tested against both existing GDrive MSIs for regression testing, plus the one mentioned in the ticket. # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Manual QA for all new/changed functionality
) Also updates said constant via this script to include 5.15.0. Idea for this is that including pre-releases as they're published ensures that by the time the corresponding Fleet release ships we have a current list, without having to cherry-pick these updates. # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Manual QA for all new/changed functionality
relates to #25062, 25063 quick fixes for UI issues with scoped software via labels feature. - [x] Manual QA for all new/changed functionality
relates to #24550 more updates to the various secret error messages after some API changes - [x] Manual QA for all new/changed functionality
…pt (#25064) See failed workflow run [here](https://github.com/fleetdm/fleet/actions/runs/12555703803) - Fix the powershell script that was broken by `.yml` auto-format - Exclude github workflow `.yml` files from prettier autoformating, since they often contain non-yaml code as part of job definitions - [ ] Manual QA for all new/changed functionality --------- Co-authored-by: Jacob Shandling <[email protected]>
## #25009 - Update validation to match pattern defined in `frontend/docs/patterns.md` - Validate email even when not enabling the feature, since we allow setting it - Remove "CONFIGURED" and "NOT CONFIGURED" copy <img width="838" alt="Screenshot 2024-12-30 at 11 27 08 AM" src="https://github.com/user-attachments/assets/42132ea2-3364-412a-bb35-2c35f9f6caea" /> <img width="838" alt="Screenshot 2024-12-30 at 11 27 16 AM" src="https://github.com/user-attachments/assets/f9f3c1c0-a166-4ea0-aaa6-b356e7cf9c69" /> <img width="838" alt="Screenshot 2024-12-30 at 11 27 24 AM" src="https://github.com/user-attachments/assets/8685d01d-b2ae-4bc5-addc-80b326f18863" /> <img width="706" alt="Screenshot 2024-12-30 at 11 44 10 AM" src="https://github.com/user-attachments/assets/af8f0f5f-588f-4226-b7e7-8cf753f4822b" /> - [x] Changes file added for user-visible changes in `changes/` - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Jacob Shandling <[email protected]>
For #25075 # Checklist for submitter - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Added/updated tests - [x] Manual QA for all new/changed functionality
## #25057 ![ezgif-6-d7867ea6c2](https://github.com/user-attachments/assets/462df801-389e-489e-8339-3b252bf24745) - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Jacob Shandling <[email protected]>
h/t binref/refinery#72, for #24720. No changes file as this is an unreleased bug. Also added output for version in the custom package parser tool. # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Manual QA for all new/changed functionality
Enable MySQL 9 tests in the nightly Go test run. The tests passed in my run: https://github.com/fleetdm/fleet/actions/runs/12552738253/job/34999129651
Noticed this hole in #25068. Fingers crossed the wording here matches what folks will search when they need to bump the cap. Also added query data discard config instructions for the UI, and moved how-to-disable instructions to the bottom of the "View a query report" section since users won't need those disclaimers until they have a few queries set up. Finally, dropped the mention of where an old UI was 25+ minor releases ago.
relates to #24681 Docs for the automatical install for fleet maintained apps.
relates to #24120 adds the `software_title_id` to the `added_app_store_activity` - [x] Added/updated automated tests - [x] Manual QA for all new/changed functionality
Related to: #24688 Changes: - Added two new dependencies: `jsonwebtoken` and `@azure/msal-node` - Added a new hook: `entra-sso`. A hook that replaces the default authentication mechanism with Microsoft Entra SSO. - Added a new action: signup-sso-user-or-redirect. This action finds or creates user records for authenticated SSO users and attaches the user record to the user's session. - updated the is-logged-in policy to check if an SSO user's token is still valid. - Added a link to the account page to the app's header navigation.
For #25076 (unreleased bug)
…y has been modified (#25115) ## #24653 - This bug was more generally that live query runs from the Edit query form did not include the `query_id` in the `run` API call. ![ezgif-6-8ef29273dc](https://github.com/user-attachments/assets/d6792037-5d91-4f6f-84d9-640133df0522) - [x] Changes file added for user-visible changes in `changes/` - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Jacob Shandling <[email protected]>
Fix bullet-point indentation
Adding some capabilities to test migration locally with ngrok. To test HTTPS.
…tware unrelease bug fix (#25490)
…tion/reassignment (#25603) Merged into `main` in #25584. Co-authored-by: Marko Lisica <[email protected]>
For #21691 cherry pick for windows disk encryption profile error message
…25697) For #25609 Video explaining the PR: https://youtu.be/bUwIdjBLqiM # Checklist for submitter - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. - [x] If database migrations are included, checked table schema to confirm autoupdate - For database migrations: - [x] Checked schema for all modified table for columns that will auto-update timestamps during migration. - [x] Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects. - [x] Ensured the correct collation is explicitly set for character columns (`COLLATE utf8mb4_unicode_ci`). - [x] Added/updated automated tests - [x] A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it) - [x] Manual QA for all new/changed functionality (cherry picked from commit 62b7412)
Issue #25874 Original PR: #25901 Co-authored-by: Ian Littman <[email protected]>
to RC for #25954 Co-authored-by: Jacob Shandling <[email protected]>
## Change file for #25305 which was a community contribution Co-authored-by: Jacob Shandling <[email protected]>
E2E tests
Steps:
🐺 If tests fail, you can relax and do nothing: your wolf pack will investigate.
|
Ran | Status | Preview | Started | Run time | Est. dev time saved |
---|---|---|---|---|---|
184 workflows | Done (Details) | Visit preview | Feb 4, 2025 at 12:16 PM (UTC) | 19 minutes | ~64 hrs |
✅ 172 passed
Preexisting bugs
![](https://camo.githubusercontent.com/4116638dd2aa3c12a472c619dd8295528d3481643b1aebf6ae597fef2d66d95a/68747470733a2f2f63646e2e7161776f6c662e6170702f696d616765732f42756749636f6e2e737667)
6 Blocking bugs
If you are aware of any of these bugs, you can set their priority to low and prevent them from causing a run failure.
View all blocking bugs
Unable to install exe file to windows host, install hangs
"Manage Automations" dropdown not visible as admin [REOPENED]
Unable to update host affected host count with command [REOPENED]
[Premium] Maintainer account is able to Manage Automations
MacOS hosts stuck in Failed status
No vulnerabilities found in Software > Vulnerabilities
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.See Changes files for more information.
SELECT *
is avoided, SQL injection is prevented (using placeholders for values in statements)cmd/osquery-perf
for new osquery data ingestion features.COLLATE utf8mb4_unicode_ci
).runtime.GOOS
).