Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clear auto install policy statuses for vpp app scope changes (#26121) #26167

Merged
merged 2 commits into from
Feb 7, 2025
Merged

fix: clear auto install policy statuses for vpp app scope changes (#26121) #26167

merged 2 commits into from
Feb 7, 2025

Conversation

jahzielv
Copy link
Contributor

@jahzielv jahzielv commented Feb 7, 2025

For #26086

cherry-pick of #26121

@jahzielv
fix: clear auto install policy statuses for vpp app scope changes (#2…
d3c7935 
…6121)

> For #26086

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [x] Added/updated automated tests
- [x] Manual QA for all new/changed functionality
@jahzielv jahzielv requested a review from a team as a code owner February 7, 2025 15:18
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 25 lines in your changes missing coverage. Please review.

Please upload report for BASE (rc-minor-fleet-v4.64.0@24582ba). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/datastore/mysql/vpp.go 67.74% 6 Missing and 4 partials ⚠️
ee/server/service/vpp.go 78.04% 6 Missing and 3 partials ⚠️
server/datastore/mysql/software_installers.go 66.66% 2 Missing and 2 partials ⚠️
ee/server/service/software_installers.go 0.00% 0 Missing and 1 partial ⚠️
server/datastore/mysql/policies.go 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.64.0   #26167   +/-   ##
=========================================================
  Coverage                          ?   63.66%           
=========================================================
  Files                             ?     1631           
  Lines                             ?   156345           
  Branches                          ?     4069           
=========================================================
  Hits                              ?    99538           
  Misses                            ?    48962           
  Partials                          ?     7845
Flag Coverage Δ
backend 64.50% <75.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

iansltx
iansltx approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the docs gen issue as well!

@jahzielv jahzielv merged commit f192c57 into rc-minor-fleet-v4.64.0 Feb 7, 2025
26 checks passed
@jahzielv jahzielv deleted the cherry-pick-26086-vpp-policy-status branch February 7, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iansltx iansltx iansltx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jahzielv @iansltx