Allow automatic creation of software install policy for VPP and FMA apps in API #26440
+215
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For #26190. Also refactors automatic policy generation so we're reusing a bit of the custom package logic, and can reuse further when doing the same thing for FMA. TODO: * Tests on new code surface * Potentially pull auto-install into VPPAppsTeams payload to minimize test diff * Add same ability to FMA * Add created_at/updated_at to VPP apps teams + migration backfill
Note that this does *not* use the queries in apps.json, as those queries are identical to what we would build programmatically by bundle ID, and this is a smaller change. We'll almost certainly need to revise this for Windows and/or FMAv2, so going with a reliable but closed-ended change for now.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26440 +/- ##
==========================================
- Coverage 63.87% 63.85% -0.02%
==========================================
Files 1662 1662
Lines 159264 159331 +67
Branches 4125 4125
==========================================
+ Hits 101724 101736 +12
- Misses 49600 49645 +45
- Partials 7940 7950 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Tested this end-to-end. So I'm not holding up the FE, I'm planning on getting automated tests on this done post-merge, over the weekend. Will set this to ready once I fix conflicts and add a changes file. |
jahzielv
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #26190. FMA is included here because the previous implementation was client-side. Does not include timestamp fields for VPP apps.
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)