Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Auto-install VPP apps #26455

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

RachelElysia
Copy link
Member

@RachelElysia RachelElysia commented Feb 19, 2025

Issue

For #26189

Description

  • New Component: SoftwareOptionsSelector, tests, styles. This component manages self-service and automatic installation options for FMA, VPP, and custom package UI for both add and edit UI.
  • New Component: SoftwareDetailsWidget which allows for reuse in other places as needed
  • Software options: Implement logic for self-service and automatic installation options, including disabling these features for iOS and iPadOS platforms.
  • Conditional rendering for info banners related to automatic software installations, for custom packages, to warn about potential issues.
  • Date Formatting Update: Updated date formatting on installer information shown replacing uploadedFromNow with addedFromNow to encompass VPP apps which aren't actually "uploaded"
  • Software Interface: Updated ISoftwareVppFormData to include properties for automatic_install and IAppStoreApp interface was updated to include properties related to automatic_install and created_at.
  • Responsive design: On adding a FMA/VPP/custom package, the two <Card/> components stack vertically when the parent us under 990px wide. Additionally, on the software details page, the software installer card pills (auto install and self service pill) move below the software information widget on low widths as well.

Screenshots / screen recordings

Screen recording (without backend)

VPPautoinstall.mp4

Add FMA page

Screenshot 2025-02-19 at 4 32 34 PM

Add VPP page

Screenshot 2025-02-19 at 4 33 19 PM

Add custom package

Screenshot 2025-02-19 at 4 28 39 PM

Edit FMA modal

Screenshot 2025-02-19 at 4 27 35 PM

Edit VPP modal

Screenshot 2025-02-19 at 4 32 10 PM

Edit VPP (with custom labels shown) modal

Screenshot 2025-02-19 at 4 27 52 PM

Edit custom package modal

Screenshot 2025-02-19 at 4 29 05 PM

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality

@RachelElysia RachelElysia force-pushed the 26189-autoinstall-vpp-fe branch from 62c98fe to 41b9b4e Compare February 19, 2025 17:17
@RachelElysia RachelElysia force-pushed the 26189-autoinstall-vpp-fe branch from 0bafdbe to 343f477 Compare February 20, 2025 15:03
@RachelElysia RachelElysia force-pushed the 26189-autoinstall-vpp-fe branch from 343f477 to 975f4a9 Compare February 20, 2025 15:05
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.86%. Comparing base (5d9026b) to head (b2e792c).

Files with missing lines Patch % Lines
frontend/services/entities/software.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #26455   +/-   ##
=======================================
  Coverage   63.85%   63.86%           
=======================================
  Files        1661     1662    +1     
  Lines      159221   159244   +23     
  Branches     4181     4144   -37     
=======================================
+ Hits       101671   101694   +23     
  Misses      49612    49612           
  Partials     7938     7938           
Flag Coverage Δ
frontend 53.77% <92.30%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RachelElysia RachelElysia marked this pull request as ready for review February 20, 2025 17:19
@RachelElysia RachelElysia requested a review from a team as a code owner February 20, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants