Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API / YAML changes] Deploy SCEP certificates from custom certificate authority #26484

Open
wants to merge 14 commits into
base: docs-v4.66.0
Choose a base branch
from
Open

[API / YAML changes] Deploy SCEP certificates from custom certificate authority #26484

wants to merge 14 commits into from

Conversation

marko-lisica
Copy link
Member

@marko-lisica marko-lisica changed the title Add integrations.scep_proxy config [API design] Deploy SCEP certificates from custom certificate authority Feb 20, 2025
@marko-lisica marko-lisica changed the title [API design] Deploy SCEP certificates from custom certificate authority [API / YAML changes] Deploy SCEP certificates from custom certificate authority Feb 20, 2025
@marko-lisica marko-lisica mentioned this pull request Feb 20, 2025
Open
54 tasks
@marko-lisica marko-lisica marked this pull request as ready for review February 20, 2025 14:29
@marko-lisica marko-lisica added the ~api-or-yaml-design Used for pull requests (PRs) with proposed API and YAML changes label Feb 20, 2025
@fleet-release fleet-release requested a review from eashaw February 20, 2025 15:07
@noahtalerman noahtalerman removed their request for review February 20, 2025 15:26
@noahtalerman noahtalerman removed their request for review February 20, 2025 18:39
@noahtalerman noahtalerman removed their request for review February 20, 2025 20:28
georgekarrv
georgekarrv reviewed Feb 21, 2025
View reviewed changes
docs/Configuration/yaml-files.md
Comment on lines +553 to +558
name: DIGICERT_WIFI
api_token: $DIGICERT_API_TOKEN
profile_id: 926dbcdd-41c4-4fe5-96c3-b6a7f0da81d8
certificate_common_name: [email protected]
certificate_subject_alternative_name: [email protected]
certificate_seat_id: [email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: DIGICERT_WIFI
api_token: $DIGICERT_API_TOKEN
profile_id: 926dbcdd-41c4-4fe5-96c3-b6a7f0da81d8
certificate_common_name: [email protected]
certificate_subject_alternative_name: [email protected]
certificate_seat_id: [email protected]
- name: DIGICERT_WIFI
api_token: $DIGICERT_API_TOKEN
profile_id: 926dbcdd-41c4-4fe5-96c3-b6a7f0da81d8
certificate_common_name: [email protected]
certificate_subject_alternative_name: [email protected]
certificate_seat_id: [email protected]

georgekarrv
georgekarrv reviewed Feb 21, 2025
View reviewed changes
docs/Configuration/yaml-files.md
Comment on lines +565 to +567
name: SCEP_VPN
server_url: https://example.com/scep
challenge: $SCEP_VPN_CHALLENGE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: SCEP_VPN
server_url: https://example.com/scep
challenge: $SCEP_VPN_CHALLENGE
- name: SCEP_VPN
server_url: https://example.com/scep
challenge: $SCEP_VPN_CHALLENGE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgekarrv georgekarrv georgekarrv left review comments

@rachaelshaw rachaelshaw Awaiting requested review from rachaelshaw rachaelshaw is a code owner

@Drew-P-drawers Drew-P-drawers Awaiting requested review from Drew-P-drawers

@eashaw eashaw Awaiting requested review from eashaw

Assignees
No one assigned
Labels
~api-or-yaml-design Used for pull requests (PRs) with proposed API and YAML changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marko-lisica @georgekarrv