Add script to help isolate environment during TUF build #26495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantecatalfamo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #26495 +/- ##
=======================================
Coverage 63.85% 63.85%
=======================================
Files 1661 1661
Lines 159221 159243 +22
Branches 4181 4181
=======================================
+ Hits 101671 101687 +16
- Misses 49612 49616 +4
- Partials 7938 7940 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sgress454
reviewed
Feb 21, 2025
|
|
||
| fleetUrl := flag.String("fleet", "", "Fleet server URL (required)") | ||
| tufUrl := flag.String("tuf", "", "TUF server URL (required)") | ||
| enrollSecret := flag.String("enroll", "", "Enroll secret (required)") |
There was a problem hiding this comment.
for consistency with other tools, I'd set this to enroll-secret
sgress454
reviewed
Feb 21, 2025
Comment on lines
+21
to
+23
| desktop := flag.Bool("desktop", false, "Generate fleet desktop") | ||
|
|
||
| fleetUrl := flag.String("fleet", "", "Fleet server URL (required)") |
There was a problem hiding this comment.
I'd do fleet-desktop and fleet-url here for consistency as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My little go program that helps isolate the environment for the TUF build process