Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - GitOps mode, 2/3 #26509

Merged
merged 58 commits into from
Feb 21, 2025
Merged

UI - GitOps mode, 2/3 #26509

merged 58 commits into from
Feb 21, 2025

Conversation

jacobshandling
Copy link
Contributor

@jacobshandling jacobshandling commented Feb 20, 2025

For #26229

This is the 2nd iterative PR for this ticket. It includes:

  • tests with a new testing utility

  • refactored argument and class names

  • another batch of UI updates

  • Added/updated automated tests

  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 53.84615% with 24 lines in your changes missing coverage. Please review.

Project coverage is 63.88%. Comparing base (a748e92) to head (3b4afa4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ons/components/IntegrationForm/IntegrationForm.tsx 0.00% 5 Missing ⚠️
...s/MdmSettings/components/IdpSection/IdpSection.tsx 0.00% 5 Missing ⚠️
frontend/components/FileDetails/FileDetails.tsx 0.00% 4 Missing ⚠️
...nsPage/cards/ChangeManagement/ChangeManagement.tsx 0.00% 4 Missing ⚠️
...min/IntegrationsPage/cards/Calendars/Calendars.tsx 0.00% 3 Missing ⚠️
frontend/components/FileUploader/FileUploader.tsx 50.00% 1 Missing ⚠️
...onents/AddIntegrationModal/AddIntegrationModal.tsx 0.00% 1 Missing ⚠️
...ryAutomationsModal/ManageQueryAutomationsModal.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26509      +/-   ##
==========================================
+ Coverage   63.86%   63.88%   +0.01%     
==========================================
  Files        1661     1661              
  Lines      159230   159170      -60     
  Branches     4109     4110       +1     
==========================================
- Hits       101700   101692       -8     
+ Misses      49590    49541      -49     
+ Partials     7940     7937       -3     
Flag Coverage Δ
frontend 53.99% <53.84%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gomEnabled?: boolean;
gitOpsModeEnabled?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure its worth putting in the changes for these four modals, as I'll have to back them completely out and add them to the PoliciesPaginatedList instead 🫤

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll back those changes out now

Copy link
Contributor

@sgress454 sgress454 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to test everything besides the MDM-specific stuff, which looks good code-wise.

@jacobshandling jacobshandling merged commit 391bd0a into main Feb 21, 2025
14 checks passed
@jacobshandling jacobshandling deleted the 25478-frontend-2 branch February 21, 2025 20:22
@jacobshandling jacobshandling changed the title UI - GitOps mode, part 2 UI - GitOps mode, 2/3 Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants