-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI - GitOps mode, 2/3 #26509
UI - GitOps mode, 2/3 #26509
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26509 +/- ##
==========================================
+ Coverage 63.86% 63.88% +0.01%
==========================================
Files 1661 1661
Lines 159230 159170 -60
Branches 4109 4110 +1
==========================================
- Hits 101700 101692 -8
+ Misses 49590 49541 -49
+ Partials 7940 7937 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
frontend/components/EnrollSecrets/EnrollSecretModal/EnrollSecretModal.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/admin/IntegrationsPage/cards/MdmSettings/WindowsMdmPage/WindowsMdmPage.tsx
Outdated
Show resolved
Hide resolved
gomEnabled?: boolean; | ||
gitOpsModeEnabled?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure its worth putting in the changes for these four modals, as I'll have to back them completely out and add them to the PoliciesPaginatedList instead 🫤
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll back those changes out now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to test everything besides the MDM-specific stuff, which looks good code-wise.
For #26229
This is the 2nd iterative PR for this ticket. It includes:
tests with a new testing utility
refactored argument and class names
another batch of UI updates
Added/updated automated tests
Manual QA for all new/changed functionality