[FL-729] [FLPY-7] Dimensioned Output #1012
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Some non-implementation changes, need to rebase again
benflexcompute
force-pushed
the
BenY/FL-729-DimensionedOutput
branch
from
9903bcc to
87f90e9
Compare
| output_fields: UniqueItemList[Union[VolumeFieldNames, str]] = pd.Field( | ||
| # TODO: Not all SolverVariables can be used here. | ||
| # TODO: `Expression` and `SolverVariable` still need business logic for validation (Surface Field/Expression?) | ||
| output_fields: UniqueItemList[Union[VolumeFieldNames, str, ValueOrExpression]] = pd.Field( |
There was a problem hiding this comment.
Since ValueOrExpression is meant to be used as a generic type (e.g. ValueOrExpression[LengthType.Vector] etc..) it might be better to just use Expression here (I think its functionally identical?)... As I understand pure values here (like 4 * u.m / u.s) make no sense here, so the field type might be slightly misleading.
| if isinstance(field, str): | ||
| udf_expression = generate_predefined_udf(field, input_params) | ||
| if udf_expression: | ||
| generated_udfs.append(UserDefinedField(name=field, expression=udf_expression)) |
There was a problem hiding this comment.
This UserDefinedField type looks very similar to what a UserVariable is - do you think we could leverage this or is there some extra business logic that we need to take care of? Maybe we could inherit?
| @@ -57,34 +57,3 @@ def is_instance_of_type_in_union(obj, typ) -> bool: | |||
|
|
|||
| # Otherwise, do a normal isinstance check. | |||
| return isinstance(obj, typ) | |||
|
|
|||
There was a problem hiding this comment.
Thanks for removing that. I forgot about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation: #992