-
Notifications
You must be signed in to change notification settings - Fork 13
Add absorption power computation to the Plasmonic Nanoparticle notebook #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add absorption power computation to the Plasmonic Nanoparticle notebook #305
Conversation
Thanks @damiano-flex this is really great! Here's a few comments:
|
…rbed power definition
Spell Check ReportPlasmonicNanoparticle.ipynb:
Checked 1 notebook(s). Found spelling errors in 1 file(s). |
@momchil-flex I addressed your comments. Let me know if this version is OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the revision! Almost there!
- In the permittivity monitor discussion, "
colocate
is set toFalse
, since the permittivity is inherently defined at the center of each grid cell." -> "colocate
is set toFalse
so that the permittivity at the Yee grid locations, exactly as used in the solver, is stored. - Could you redo the
web.run
call so the outptut is actually shown? - In the absorption spectrum labels, how about we use "Tidy3D:
$P_{abs}$ " and "Tidy3D: I - S", and comment in the text whatI - S
(incoming minus scattered power) stands for. - Can we give a reference for the absorbed power density?
- I know this didn't come from you, but in the end, in this sentence "Since the sphere's material is dispersive, no subpixel averaging scheme is applied", let's replace "dispersive" with "metallic". We actually apply subpixel to dispersive dielectrics.
This PR introduces the computation of the total power absorption and the absorption power density in the Plasmonic nanoparticle notebook. The changes are the following: