feat[adjoint]: Add conductivity gradient for CustomMedium
#2582
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
Diff CoverageDiff: origin/develop...HEAD, staged and unstaged changes
Summary
|
There was a problem hiding this comment.
LGTM
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
yaugenst-flex
force-pushed
the
yaugenst-flex/conductivity-grads
branch
2 times, most recently
from
1b5e0be to
00cce22
Compare
Introduces support for computing gradients with respect to the `conductivity` field in `CustomMedium`.
To achieve this, the derivative computation logic was generalized:
- The `_derivative_field_cmp` method is refactored to accept a `component` parameter ('real', 'imag', 'complex') to compute the VJP for different parts of the complex permittivity.
- For the 'imag' component, the derivative is scaled by `1 / (omega * epsilon_0)` to convert from derivative w.r.t. complex permittivity to derivative w.r.t. conductivity.
- The `_compute_derivatives` dispatcher now handles the new `"conductivity"` parameter path.
- A new autograd test is added to validate the conductivity gradient calculation on a `CustomMedium` with constant permittivity.
yaugenst-flex
force-pushed
the
yaugenst-flex/conductivity-grads
branch
from
20bc219 to
7e50b67
Compare
good point, fixed |
| monitor, postprocess = make_monitors()["field_point"] | ||
|
|
||
| def objective(params): | ||
| """Objective function testing only gonductivity gradient (constant permittivity).""" |
There was a problem hiding this comment.
gonductivity -> conductivity
There was a problem hiding this comment.
looks good! not sure this would be in the scope of the PR or not but would love to have a numerical test for conductivity as well. I'm happy to take this on at some point, think I could modify the field and/or mode numerical tests we have to check conductivity (right now, they use custom medium for permittivity, but should be quick change to also test conductivity.
Summary
This PR introduces the capability to compute gradients with respect to the
conductivityof aCustomMedium.Implementation Details
_derivative_field_cmphelper method with a newcomponentparameter that can be set to'real','imag', or'complex'.component='imag') by scaling the imaginary part of the complex permittivity derivative by1 / (omega * epsilon_0)._compute_derivativesdispatcher to handle the new"conductivity"parameter path and invoke the generalized helper method.test_custom_medium_conductivity_only_gradientto validate the gradient calculation for aCustomMediumwith variable conductivity and constant permittivity.custom_med_with_conductivity, that contains both variable permittivity and conductivity.Greptile Summary
Implements conductivity gradient calculations for
CustomMediumby extending the permittivity gradient framework to handle real, imaginary, and complex components, enabling material conductivity optimization.componentparameter to_derivative_field_cmpto support 'real', 'imag', and 'complex' gradient types1/(omega * epsilon_0)custom_med_with_conductivityto validate combined permittivity and conductivity gradientstest_autograd.pyto improve maintainability with shared coordinate dictionaries