dmod: Make more robust when used outside default folders #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The snippet expansion is now split into two distinct parts: the namespace and the module name. The namespace expansion looks for a `lib|test|spec` folder and uses any folder below that as the namespace, joined by dots. If no `lib|test|spec` folder can be found, no namespace will be generated. The module name is generated through the `TM_FILENAME_BASE`, and is basically the same as it was before. But this allows us to generate a `defmodule Config` module in `config/config.exs`.
|
W⦿‿⦿t! |
florinpatrascu
added a commit
that referenced
this pull request
Mar 26, 2021
…path and line number. Label string can easily be discarded inspired bby this [tip](https://elixirstream.dev/tips/7bca7ae3-1431-4bb1-bf2c-1ee3c5390a40) I added my own take on it. Hopefully you can enjoy this newer version as much as I do :) - dmod: Make more robust when used outside default folders #13 - ^^^ Thank you @sascha-wolf <3
|
published! also added a new one iins ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snippet expansion is now split into two distinct parts: the namespace and the module name.
The namespace expansion looks for a
lib|test|specfolder and uses any folder below that as the namespace, joined by dots. If nolib|test|specfolder can be found, no namespace will be generated.The module name is generated through the
TM_FILENAME_BASE, and is basically the same as it was before. But this allows us to generate adefmodule Configmodule inconfig/config.exs.Before
Expanding
dmodinlib/foo/bar/baz.exswould result in:But expanding
dmodinconfig/foo/bar/baz.exswould result in:Which is certainly unexpected.
After
Expanding
dmodinlib/foo/bar/baz.exswould result in:And expanding
dmodinconfig/foo/bar/baz.exswould result in:Which is not as nice as the
libversion above but at least a usable module name. 🙂