Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

couple of fixes, additions and a more generic approach... #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

couple of fixes, additions and a more generic approach... #7

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 17, 2015

:)

@flouthoc
Copy link
Owner

@vincfalk Thanks for the pull request i'll merge it ASAP after verification 😃 👍

@flouthoc
Copy link
Owner

flouthoc commented Feb 8, 2019

Could you please take care of conflicts ?

@ghost
Copy link

ghost commented Aug 24, 2019

(Looks like there wasn't a response because the account that made this request is now deleted...)
I am pretty new when it comes to AJAX requests, but I was able to understand what this guy did at the bottom of index.js. What do you think he meant by this?

var XMLHTTPtypes = [
function() { return new XMLHttpRequest(); },
function() { return new ActiveXObject("Msxml3.XMLHTTP"); },
function() { return new ActiveXObject("Msxml2.XMLHTTP.6.0"); },
function() { return new ActiveXObject("Msxml2.XMLHTTP.3.0"); },
function() { return new ActiveXObject("Msxml2.XMLHTTP"); },
function() { return new ActiveXObject("Microsoft.XMLHTTP"); }
];
// return the appropriate object
function XMLhttp() {
if(this instanceof XMLhttp) {
XMLHTTPtypes.forEach(function(t) {
try { xmlhttp = t(); }
catch(e) {}
});
return xmlhttp;

@flouthoc
Copy link
Owner

@ForgivenNin I think author was trying to handle XMLHTTP object for some browsers explicitly.

@ghost
Copy link

ghost commented Sep 7, 2019

Would it be of any use if we had this implemented? Or is this already done by the browser?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants