Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installation-spell): print logs on a service #291

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .fluence/secrets/integration-tests-key.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3DqrJbuj/H4cRdu0zq5eXdjcqwBJ3OgmUr7Htr3WiBw=
4 changes: 4 additions & 0 deletions .github/e2e/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ services:
# - --bootstraps=/dns/nox-1/tcp/7771
# 12D3KooWBM3SdXWqGaawQDGQ6JprtwswEg3FWGvGhmgmMez1vRbR
- -k=hK62afickoeP2uZbmSkAYXxxqP8ozq16VRN7qfTP719EHC5V5tjrtW57BSjUr8GvsEXmJRbtejUWyPZ2rZMyQdq
- --enable-system-services=none
- --management-key=12D3KooWGLAmtTkqZqqKiSxXpb2j1SRjpbE2YgZZb4Unzn5VPj9p
- --dev-mode
networks:
nox:
ipv4_address: 10.50.10.10

2 changes: 0 additions & 2 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ jobs:
- snapshot
uses: fluencelabs/nox/.github/workflows/build.yml@master
with:
ref: restrict-effectors
cargo-dependencies: |
[
{
Expand Down Expand Up @@ -93,7 +92,6 @@ jobs:

uses: fluencelabs/nox/.github/workflows/tests.yml@master
with:
ref: restrict-effectors
cargo-dependencies: |
[
{
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:
working-directory: ./src/spell/modules/spell/spell
run: ./build.sh

- uses: pnpm/action-setup@v2.2.4
- uses: pnpm/action-setup@v2.4.1
with:
version: 8

Expand Down Expand Up @@ -167,7 +167,7 @@ jobs:
--skip-published \
--yes

- uses: pnpm/action-setup@v2.2.4
- uses: pnpm/action-setup@v2.4.1
with:
version: 8

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
ref: ${{ github.ref }}

- name: Setup pnpm
uses: pnpm/action-setup@v2.2.4
uses: pnpm/action-setup@v2.4.1
with:
version: 8

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/snapshot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ jobs:
path: src/spell/modules/spell

- name: Setup pnpm
uses: pnpm/action-setup@v2.2.4
uses: pnpm/action-setup@v2.4.1
with:
version: 8

Expand Down
2 changes: 1 addition & 1 deletion README
Original file line number Diff line number Diff line change
@@ -1 +1 @@
# Spell
# Spell Repo
8 changes: 6 additions & 2 deletions integration-tests/framework.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,17 @@ def make_key():
return name



def delete_key(name):
with key_lock:
c = delegator.run(f"fluence key remove {name} --no-input", block=True)
if len(c.err) != 0:
print(c.err)
return name

def get_key():
return 'integration-tests-key'


def get_relays():
env = os.environ.get("FLUENCE_ENV")
Expand Down Expand Up @@ -228,7 +232,7 @@ def init_param_opt(param_name):
old_setup_class = getattr(cls, "setup_class", None)

def setup_class(cls):
key_pair_name = make_key()
key_pair_name = get_key()
spell_id = create_spell(key_pair_name, air_script, config, dat, alias)
cls.spell_id = spell_id
cls.key_pair_name = key_pair_name
Expand All @@ -245,7 +249,7 @@ def teardown_class(cls):
if old_teardown_class is not None:
old_teardown_class()
destroy_spell(cls.key_pair_name, cls.spell_id)
delete_key(cls.key_pair_name)
#delete_key(cls.key_pair_name)

cls.teardown_class = teardown_class

Expand Down
8 changes: 4 additions & 4 deletions src/aqua/installation-spell/src/aqua/spell.aqua
Original file line number Diff line number Diff line change
Expand Up @@ -161,11 +161,11 @@ func download_service(s: Service, ipfs: Multiaddr) -> []Hash:
for m <- s.modules:
get_wasm <- get_from(HOST_PEER_ID, m.wasm, ipfs)
if get_wasm.success:
on HOST_PEER_ID:
try:
try:
on HOST_PEER_ID:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that need to be executed on host and not on worker?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because aqua-ipfs is available only on host.

hashes <<- Dist.add_module_bytes_from_vault(m.name, get_wasm.path)
catch e:
log([s.name, "error adding module", m.name, e])
catch e:
log([s.name, "error adding module", m.name, e])
else:
log([s.name, "error retrieving module", m.name, ["wasm", m.wasm, get_wasm]])
<- hashes
Expand Down
Loading