Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove so exessively #401

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Nov 25, 2024

In the previous version, it will remove required runtime so with find && rm.

This is apparently bug with it.

See fluent/fluent-plugin-s3#449

In the previous version, it will remove required runtime
so with find && rm.

This is apparently bug with it.

See fluent/fluent-plugin-s3#449

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys
Copy link
Contributor Author

kenhys commented Nov 25, 2024

Now build image contains lib/jso/ext/*.so

podman exec -it 5c1752a119cd /bin/bash
fluent@5c1752a119cd:/$ find /usr/local/bundle/gems/ -name 'json'
/usr/local/bundle/gems/json-2.7.4/lib/json
fluent@5c1752a119cd:/$ find /usr/local/bundle/gems/json-2.7.4/
/usr/local/bundle/gems/json-2.7.4/
/usr/local/bundle/gems/json-2.7.4/COPYING
/usr/local/bundle/gems/json-2.7.4/README.md
/usr/local/bundle/gems/json-2.7.4/lib
/usr/local/bundle/gems/json-2.7.4/lib/json
/usr/local/bundle/gems/json-2.7.4/lib/json/version.rb
/usr/local/bundle/gems/json-2.7.4/lib/json/ext.rb
/usr/local/bundle/gems/json-2.7.4/lib/json/add
/usr/local/bundle/gems/json-2.7.4/lib/json/add/ostruct.rb
/usr/local/bundle/gems/json-2.7.4/lib/json/add/date.rb
/usr/local/bundle/gems/json-2.7.4/lib/json/add/bigdecimal.rb
/usr/local/bundle/gems/json-2.7.4/lib/json/add/rational.rb
/usr/local/bundle/gems/json-2.7.4/lib/json/add/complex.rb
/usr/local/bundle/gems/json-2.7.4/lib/json/add/regexp.rb
/usr/local/bundle/gems/json-2.7.4/lib/json/add/symbol.rb
/usr/local/bundle/gems/json-2.7.4/lib/json/add/time.rb
/usr/local/bundle/gems/json-2.7.4/lib/json/add/core.rb
/usr/local/bundle/gems/json-2.7.4/lib/json/add/range.rb
/usr/local/bundle/gems/json-2.7.4/lib/json/add/struct.rb
/usr/local/bundle/gems/json-2.7.4/lib/json/add/exception.rb
/usr/local/bundle/gems/json-2.7.4/lib/json/add/date_time.rb
/usr/local/bundle/gems/json-2.7.4/lib/json/add/set.rb
/usr/local/bundle/gems/json-2.7.4/lib/json/ext
/usr/local/bundle/gems/json-2.7.4/lib/json/ext/generator.so
/usr/local/bundle/gems/json-2.7.4/lib/json/ext/parser.so
/usr/local/bundle/gems/json-2.7.4/lib/json/ext/generator
/usr/local/bundle/gems/json-2.7.4/lib/json/ext/generator/state.rb
/usr/local/bundle/gems/json-2.7.4/lib/json/pure
/usr/local/bundle/gems/json-2.7.4/lib/json/pure/generator.rb
/usr/local/bundle/gems/json-2.7.4/lib/json/pure/parser.rb
/usr/local/bundle/gems/json-2.7.4/lib/json/common.rb
/usr/local/bundle/gems/json-2.7.4/lib/json/generic_object.rb
/usr/local/bundle/gems/json-2.7.4/lib/json/pure.rb
/usr/local/bundle/gems/json-2.7.4/lib/json.rb
/usr/local/bundle/gems/json-2.7.4/json.gemspec
/usr/local/bundle/gems/json-2.7.4/LEGAL
/usr/local/bundle/gems/json-2.7.4/BSDL
/usr/local/bundle/gems/json-2.7.4/CHANGES.md

@kenhys kenhys requested a review from Watson1978 November 25, 2024 09:42
Copy link

@Watson1978 Watson1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@kenhys kenhys merged commit 8186b4c into fluent:master Nov 25, 2024
5 checks passed
@kenhys kenhys deleted the donot-purge-ext-excessively branch November 25, 2024 09:44
@kenhys kenhys mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants