metrics: add getter method automatically #4978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watson1978
force-pushed
the
add-metrics-getter
branch
4 times, most recently
from
53929d6 to
150c0eb
Compare
Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Shizuo Fujita <[email protected]>
Watson1978
force-pushed
the
add-metrics-getter
branch
from
150c0eb to
0343c40
Compare
daipom
approved these changes
May 28, 2025
There was a problem hiding this comment.
LGTM. Thanks!
Note: It is unclear whether these getters are necessary.
We keep them just in case.
This PR saves us from having to bother with these getters.
If a third-party plugin intentionally has a getter, it will not be overwritten.
There will be no impact from this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
This PR aim to refactor preparing the getter method of metrics.
In addition, the methods are defined automatically, it prevents we forget to add getter.
Docs Changes:
#4978
Release Note:
Same as the title.