-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New Feature Document Scanner #605
feat: New Feature Document Scanner #605
Conversation
Fix access to activity in onAttachedToActivity & add result to response
Great result ! Good job guys |
I will review, after that I will merge and release a new version. I the meantime use @bensonarafat fork if you need the feature. |
packages/google_mlkit_document_scanner/ios/google_mlkit_document_scanner.podspec
Outdated
Show resolved
Hide resolved
@bensonarafat : could address the comments and also make sure that the link job passes. |
|
use path to pass it, and also make sure the job is added to this file: https://github.com/flutter-ml/google_ml_kit_flutter/blob/develop/.github/workflows/flutter.yml they are arrange in alphabetical order. |
Yeah, i finally got it. Update: |
packages/google_mlkit_document_scanner/android/gradle/wrapper/gradle-wrapper.properties
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,238 @@ | |||
package com.google_mlkit_document_scanner; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow the same design we have for the other plugins. You should have 2 files: DocumentScanner.java
and GoogleMlKitDocumentScannerPlugin.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fbernaly
Yeah! About that.
Separating the file won't work.
I did that initially, but we need to have the FlutterPlugin
and ActivityAware
on the same abstract class for the onAttachedToActivity
to work for some reason. I spent sometime on it.
@bensonarafat : I have more comments. |
Updated. My comment on separating the class |
@@ -0,0 +1,4 @@ | |||
#import <Flutter/Flutter.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name of this file should be:
GoogleMlKitDocumentScannerPlugin.h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, i thought i changed this.
@@ -0,0 +1,20 @@ | |||
#import "GoogleMlKitDocumentScannerPlugin.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name of this file should be:
GoogleMlKitDocumentScannerPlugin.m
@bensonarafat : I added some more comments, and branch is out-of date, update branch. |
@fbernaly Branch updated and review updated |
@bensonarafat : thanks for your contribution, I am merging this into feature/doc_scanner and play with it, once I confirm the feature is working as expected I will merge into master and cut a release. |
Document Scanner feature based the new feature request #581
Key point to note:
Document Scanner is currently in Beta, and not currently available for iOS (I will stay updated and update this feature when available)
Read more on the Google ML doc
Thanks ablause on the
onAttachedToActivity
issueTest Sample
2.mp4