Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated text recognition dependency #613

Merged
merged 3 commits into from
Apr 20, 2024

Conversation

Mikkelet
Copy link
Contributor

@Mikkelet Mikkelet commented Apr 20, 2024

Update dependency to fix restraints bug from #612

@Mikkelet Mikkelet changed the title 612: Updated text recognition dependency chore: Updated text recognition dependency Apr 20, 2024
@Mikkelet Mikkelet changed the title chore: Updated text recognition dependency fix: Updated text recognition dependency Apr 20, 2024
@fbernaly
Copy link
Collaborator

@Mikkelet: where did you find that latest dependencies? I am in the process of releasing a new version. Could you also update the podspecs for the other plugin as well.

@fbernaly
Copy link
Collaborator

Also, update your branch with the latest code we just merged.

@Mikkelet
Copy link
Contributor Author

Mikkelet commented Apr 20, 2024

Yeah their website doc is lacking, had to go into their sample apps to get the right version:

https://github.com/googlesamples/mlkit/tree/master/ios/quickstarts
https://github.com/googlesamples/mlkit/blob/master/ios/quickstarts/vision/Podfile

I can see you've commented-out the dependency of Document Scanner and FaceMeshDetection. I couldn't find any versions for these in the sample apps, so I assume they're only available for Android?

@fbernaly
Copy link
Collaborator

They are no available for iOS yet, only android.

@fbernaly
Copy link
Collaborator

Thanks for your contribution. I am merging this, and releasing on Monday.

@fbernaly fbernaly merged commit 24d91f8 into flutter-ml:develop Apr 20, 2024
2 checks passed
@fbernaly
Copy link
Collaborator

@Mikkelet: I tried to run those with the example app and it is not able to find version 6.0.0, it finds 5.0.0. Did you test the changes with the example app? give it a try an update accordingly. Submit a new PR with the changes.

@Mikkelet
Copy link
Contributor Author

Mikkelet commented Apr 21, 2024

ah no, sorry, I assumed that the versions used in the official sample apps would be correct, but I can see now that they are not.. or rather, they wont compile in the example project at least.

I also tried with going back to my initial commit where I only updated the version for text-recognition, but something weird is happening. When I update to 6.0.0, I can compile my flutter project, but not the example project. When I downgrade to 4.0.0, I can compile the example project, but not my personal project. Any clues to why that is?

@fbernaly
Copy link
Collaborator

Try 5.0.0 that works in the example. Send a PR with those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants