refactor: Adds better error handling for image format YUV_420_888. #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panmari
changed the title
fbernaly
requested changes
Jan 8, 2025
...google_mlkit_commons/android/src/main/java/com/google_mlkit_commons/InputImageConverter.java
Outdated
Show resolved
Hide resolved
panmari
force-pushed
the
imageerror
branch
3 times, most recently
from
43755fc to
327d0df
Compare
fbernaly
reviewed
Jan 8, 2025
...google_mlkit_commons/android/src/main/java/com/google_mlkit_commons/InputImageConverter.java
Show resolved
Hide resolved
|
And update branch, it is out-of-date |
This format can not be read by the InputImage.fromByteArray API, as documented at https://developers.google.com/android/reference/com/google/mlkit/vision/common/InputImage#public-static-inputimage-frombytearray-byte[]-bytearray,-int-width,-int-height,-int-rotationdegrees,-int-format. Converting the bytes received here to the right type (android.media.Image) is non-trivial. Additionally improving error handling by passing along stack traces when possible.
|
Rebased, as requested. |
fbernaly
reviewed
Jan 8, 2025
| byte[] data = (byte[]) Objects.requireNonNull(imageData.get("bytes")); | ||
| int imageFormat = Integer.parseInt(Objects.requireNonNull(metaData.get("image_format")).toString()); | ||
| int rotationDegrees = Integer.parseInt(Objects.requireNonNull(metaData.get("rotation")).toString()); | ||
| int width = Double.valueOf(Objects.requireNonNull(metaData.get("width")).toString()).intValue(); |
There was a problem hiding this comment.
change this to:
int width = Integer.parseInt(Objects.requireNonNull(metaData.get("width")).toString());
do the same for height
There was a problem hiding this comment.
I apologize, I think I was too quick at resolving the last comment on this.
On the dart side, where this JSON object is created, it is set as double. That is because the dart type of Size.weight and Size.height is double.
Considering that, I feel the code does the right thing.
fbernaly
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This format can not be read by the InputImage.fromByteArray API, as documented at https://developers.google.com/android/reference/com/google/mlkit/vision/common/InputImage#public-static-inputimage-frombytearray-byte[]-bytearray,-int-width,-int-height,-int-rotationdegrees,-int-format.
Converting the bytes received here to the right type (android.media.Image) is non-trivial.
Additionally improving error handling by passing along stack traces when possible.