Skip to content

[in_app_purchase_storekit] Make Storekit 2 the default #9178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

LouiseHsu
Copy link
Contributor

Make Storekit 2 the default. Fixes flutter/flutter#159871

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@LouiseHsu LouiseHsu requested a review from hellohuanlin April 29, 2025 23:44
@hellohuanlin
Copy link
Contributor

I saw you requested review but it's still "Draft" mode. is it ready to review?

@@ -1,3 +1,7 @@
## 0.3.23

* **BREAKING CHANGE:** StoreKit 2 is now the default for all devices that support it.
Copy link
Contributor

@hellohuanlin hellohuanlin Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be 0.4.0 instead? iirc breaking change should be major bump, but this is still 0. version, so a minor bump?
(cc @stuartmorgan-g for advice)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, breaking changes need a "major" (which for pre-1.0 is the second number, per Dart convention) version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[in_app_purchase_storekit] Make StoreKit2 the default for all supported devices.
3 participants