-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[in_app_purchase_storekit] Make Storekit 2 the default #9178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I saw you requested review but it's still "Draft" mode. is it ready to review? |
@@ -1,3 +1,7 @@ | |||
## 0.3.23 | |||
|
|||
* **BREAKING CHANGE:** StoreKit 2 is now the default for all devices that support it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be 0.4.0
instead? iirc breaking change should be major bump, but this is still 0.
version, so a minor bump?
(cc @stuartmorgan-g for advice)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, breaking changes need a "major" (which for pre-1.0 is the second number, per Dart convention) version bump.
Make Storekit 2 the default. Fixes flutter/flutter#159871
Pre-Review Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].CHANGELOG.md
to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].///
).