Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Material 3 progress indicators and slider guides for theme migration #11733

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

TahaTesser
Copy link
Member

Fixes Update slider and progress indicator migration guides with year2023 flag from component themes

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Feb 21, 2025

Visit the preview URL for this PR (updated for commit 4dea60c):

https://flutter-docs-prod--pr11733-update-m3-guides-fkcx5me7.web.app

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these clarifications for these design updates!

I have a question and a few small suggestions. I only made the suggestions for the first one, but they apply to each instance.


```dart highlightLines=2
return MaterialApp(
theme: ThemeData(progressIndicatorTheme: const ProgressIndicatorThemeData(year2023: false)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this out and it's saying the year2023 parameter and corresponding property are deprecated?

Copy link
Member Author

@TahaTesser TahaTesser Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we added this flag with deprecation a few months ago to encourage users to read the migration steps and opt in the design.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually, we'll toggle the default value so users won't need to use the flag for the new design.

Copy link
Member

@parlough parlough Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks! It's a bit confusing though, as it's a deprecation warning, but in this case, you don't want to remove it.

Should we add an ignore comment to these snippets with an explanation of why the diagnostic is ignored?

Copy link
Member Author

@TahaTesser TahaTesser Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the deprecation message:

    @Deprecated(
      'Set this flag to false to opt into the 2024 progress indicator appearance. Defaults to true. '
      'In the future, this flag will default to false. Use ProgressIndicatorThemeData to customize individual properties. '
      'This feature was deprecated after v3.26.0-0.1.pre.',
    )
    this.year2023,

This message explains what will happen to the default value in the future and this flag isn't permanent hence the deprecation. Adding message to ignore will defeat the purpose of deprecation message.

@TahaTesser TahaTesser requested a review from parlough February 25, 2025 09:34
@TahaTesser TahaTesser changed the title Update Material 3 progress indicators and slider guides for migration… Update Material 3 progress indicators and slider guides for theme migration Feb 25, 2025
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and the adjustments @TahaTesser! Looks good to me.

Optionally do consider a comment or note like I mentioned in https://github.com/flutter/website/pull/11733/files#r1970471078.

@TahaTesser TahaTesser merged commit 92b003a into flutter:main Feb 26, 2025
9 checks passed
@TahaTesser TahaTesser deleted the update_m3_guides branch February 26, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update slider and progress indicator migration guides with year2023 flag from component themes
3 participants