Avoid running traffic increase hooks after the last increase step has already been completed (and analyzed) #1500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an improvement on the PR #1470 which was released in version v1.33.0.
The goal is for the traffic increase webhook to only run when the next step is actually a traffic increase.
Without this change, Flagger will still be calling the traffic increase webhook even after the last increase step has already been analyzed, right before the verification promotion webhook.
The code logic can be compared with the promotion webhook call (already on the code):
flagger/pkg/controller/scheduler.go
Lines 591 to 595 in dfc0c96