Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Knative #1682

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tombanksme
Copy link

This is a proof-of-concept pull request to add the canary release deployment strategy for Knative (#903). It's far from production ready but I wanted to see if there's appetite for this feature before I invest more time into completing it.

Currently Flagger can target a Knative service & complete the canary release process. I've not tested rollbacks yet although I think it should just work. The pull request needs some extra work to add test coverage; throw errors when using unsupported release processes & add Knative specific Kubernetes events.

Let me know what you think!

Example

The following canary will target a Knative Service. Once the canary has been initialised you can start the canary release process by creating a new revision of the service.

apiVersion: flagger.app/v1beta1
kind: Canary
metadata:
  name: example
spec:
  targetRef:
    apiVersion: serving.knative.dev/v1
    kind: Service
    name: example
  service:
    port: 3000
  analysis:
    interval: 1m
    threshold: 10
    maxWeight: 50
    stepWeight: 5

@tombanksme tombanksme marked this pull request as ready for review July 15, 2024 12:40
@edude03
Copy link

edude03 commented Sep 3, 2024

(I haven't used flagger / knative in awhile but) I'm very excited to see this taking shape!

@arubino
Copy link

arubino commented Oct 4, 2024

Hi @tombanksme! This looks great, are there any news on this PR?

@tombanksme
Copy link
Author

I haven't heard anything back from the Flagger maintainers. I would be happy to finish up the PR if it's something that fluxcd would consider merging.

@aryan9600
Copy link
Member

while i see the value added by this PR, is it not possible to use Gateway API as a bridge to get Flagger and Knative to work together: https://github.com/knative-extensions/net-gateway-api

@tombanksme
Copy link
Author

tombanksme commented Nov 27, 2024

Sorry for the delay. It looks like net-gateway-api isn't ready for production yet according to the readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants