-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Kubernetes 1.28.x, Helm v3.13.2 and Kustomize v5.2.1 #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- github.com/fluxcd/pkg/apis/kustomize to v1.2.0 - github.com/fluxcd/pkg/apis/meta to v1.2.0 - k8s.io/apiextensions-apiserver to v0.28.4 - k8s.io/apimachinery to v0.28.4 - sigs.k8s.io/controller-runtime to v0.16.3 - sigs.k8s.io/yaml to v1.4.0 Signed-off-by: Hidde Beydals <[email protected]>
- github.com/fluxcd/cli-utils to v0.36.0-flux.1 - github.com/fluxcd/pkg/apis/event to v0.6.0 - github.com/fluxcd/pkg/apis/kustomize to v1.2.0 - github.com/fluxcd/pkg/apis/meta to v1.2.0 - github.com/fluxcd/pkg/runtime to v0.43.0 - github.com/fluxcd/pkg/ssa to v0.34.0 - github.com/fluxcd/pkg/testserver to v0.5.0 - github.com/go-logr/logr to v1.3.0 - github.com/google/go-cmp to v0.6.0 - github.com/hashicorp/go-retryablehttp to v0.7.5 - github.com/onsi/gomega to v1.30.0 - github.com/opencontainers/go-digest to v1.0.1-0.20231025023718-d50d2fec9c98 - github.com/opencontainers/go-digest/blake3 to v0.0.0-20231025023718-d50d2fec9c98 - golang.org/x/text to v0.14.0 - helm.sh/helm/v3 to v3.13.2 - k8s.io/api to v0.28.4 - k8s.io/apiextensions-apiserver to v0.28.4 - k8s.io/apimachinery to v0.28.4 - k8s.io/cli-runtime to v0.28.4 - k8s.io/client-go to v0.28.4 - k8s.io/kubectl to v0.28.4 - k8s.io/utils to v0.0.0-20231121161247-cf03d44ff3cf - sigs.k8s.io/controller-runtime to v0.16.3 - sigs.k8s.io/kustomize/api to v0.15.0 - sigs.k8s.io/kustomize/kyaml to v0.15.0 - sigs.k8s.io/yaml to v1.4.0 Signed-off-by: Hidde Beydals <[email protected]>
Due to switch to a hard fork of goyaml. Signed-off-by: Hidde Beydals <[email protected]>
Helm v3.13.x includes a change which causes labels to be magically set during writes to the storage, without persisting them to the release object which is passed to the interface. Because of this, at the time of observing the initial write to the storage we would not see them, but once we are verifying them we would. Causing the calculated digest to always differ, and making the controller think the storage item had changed. While I am of opinion it would be better for Helm to set the labels on the release object as soon as they are persisted to the storage, the only solution now for us is to ignore them. Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
changed the title
Update to Kubernetes 1.28.x and Kustomize v5.2.1
Update to Kubernetes 1.28.x, Helm v3.13.2 and Kustomize v5.2.1
Nov 24, 2023
stefanprodan
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @hiddeco 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
k8s.io
packages to v0.28.4sigs.k8s.io/kustomize
to v5.2.1sigs.k8s.io/controller-runtime
to v0.16.3 and adapt to breaking changessigs.k8s.io/cli-utils
togithub.com/fluxcd/cli-utils
sigs.k8s.io/yaml
and Helm v3.13.x changesPart of: fluxcd/flux2#3991 and fluxcd/flux2#4410
Fixes: #809