feat: be able to import any k8s obj as source #1321
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several significant changes to the
kustomization_controller
to enhance the discovery and handling of source references, as well as adding new tests to ensure functionality. The most important changes include adding aDiscoveryClient
to theKustomizationReconciler
, refactoring the source retrieval logic, and adding a new test for theSourceRefAPIVersion
.Enhancements to
KustomizationReconciler
:DiscoveryClient
to theKustomizationReconciler
struct for dynamic API discovery. (internal/controller/kustomization_controller.go
)Source
type and refactored thegetSource
method to useunstructured.Unstructured
for dynamic API version handling. (internal/controller/kustomization_controller.go
)Codebase updates:
discovery
package in multiple files. (internal/controller/kustomization_controller.go
,internal/controller/suite_test.go
,main.go
) [1] [2] [3]main
function to initializeDiscoveryClient
and pass it to theKustomizationReconciler
. (main.go
)Testing improvements:
TestKustomizationReconciler_SourceRefAPIVersion
to verify the correct handling ofSourceRef
API versions. (internal/controller/kustomization_controller_test.go
)DiscoveryClient
. (internal/controller/suite_test.go
)