Add insecure-allow-http flag to block HTTP traffic
#531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryan9600
force-pushed
the
rfc-insecure-http
branch
from
f12f508
to
784b870
Compare
Add a new flag `insecure-allow-http` that blocks the controller from reaching any HTTP endpoints. Its set to true by default to avoid making a breaking change. If HTTP traffic is disabled and a `Provider` specifies an address with the `http` scheme, the reconciler errors out and uses the `InsecureConnectionsDisallowed` reason for the object's conditions. Ref: https://github.com/fluxcd/flux2/tree/main/rfcs/0004-insecure-http Signed-off-by: Sanskar Jaiswal <[email protected]>
aryan9600
force-pushed
the
rfc-insecure-http
branch
from
784b870
to
e0df51d
Compare
darkowlzz
reviewed
Jun 7, 2023
| @@ -253,6 +273,10 @@ func (r *ProviderReconciler) validateCredentials(ctx context.Context, provider * | |||
| } | |||
| } | |||
|
|
|||
| if err := parseURLs(address, proxy, r.BlockInsecureHTTP); err != nil { | |||
There was a problem hiding this comment.
Can this PR wait until #540 which is trying to remove the provider and alert reconcilers as a whole ?
validateCredentials() is doing more than just validating the credentials and there's a copy of it in the event handler as well. With #540, this implementation will change. Instead of setting a status, it'll become a dispatch failed warning event on the respective alert object, and maybe on the provider object too. Maybe RFC-0004 can be updated to mention how this should be reflected on status-less objects via k8s events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new flag
insecure-allow-httpthat blocks the controller from reaching any HTTP endpoints. Its set to true by default to avoid making a breaking change. If HTTP traffic is disabled and aProviderspecifies an address with thehttpscheme, the reconciler errors out and uses theInsecureConnectionsDisallowedreason for the object's conditions.Ref: https://github.com/fluxcd/flux2/tree/main/rfcs/0004-insecure-http
Fixes: #386