Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in-memory kustomize builds advice to scaling docs #1720

Merged
merged 2 commits into from
Nov 19, 2023
Merged

Add in-memory kustomize builds advice to scaling docs #1720

merged 2 commits into from
Nov 19, 2023

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Nov 17, 2023 •
edited
Loading

Recommend using tmpfs based on benchmark results from https://github.com/stefanprodan/flux-benchmark

Part of: fluxcd/flux2#4410

@stefanprodan stefanprodan added area/docs Documentation related issues and pull requests area/flux Flux related issues and pull requests labels Nov 17, 2023
@stefanprodan stefanprodan requested a review from hiddeco November 17, 2023 10:34
makkes
makkes reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@makkes makkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a note that using tmpfs will count against the pod's memory usage. I wouldn't expect this to have a huge impact in most of the cases but depending on the number of manifests it might pose an issue.

@stefanprodan
Copy link
Member Author

stefanprodan commented Nov 18, 2023 •
edited
Loading

Preview here: https://deploy-preview-1720--fluxcd.netlify.app/flux/installation/configuration/vertical-scaling/

makkes
makkes approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@makkes makkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@stefanprodan stefanprodan merged commit b4a5629 into main Nov 19, 2023
5 checks passed
@stefanprodan stefanprodan deleted the tmpfs-docs branch November 19, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makkes makkes makkes approved these changes

@hiddeco hiddeco Awaiting requested review from hiddeco

Assignees
No one assigned
Labels
area/docs Documentation related issues and pull requests area/flux Flux related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanprodan @makkes