Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FluxCD Azure DevOps article resource #2097

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Conversation

kingdonb
Copy link
Member

@kingdonb kingdonb commented Nov 25, 2024

Testing the Resources / Article feature again. (also #2096)

Thanks Mohammed Nour for contributing this article about the new features in Flux 2.4 🎉

(I asked if there was a branding image that goes with this blog, and it was suggested we just use the Flux logo as there isn't one.)

@kingdonb
Copy link
Member Author

https://deploy-preview-2097--fluxcd.netlify.app/resources/

I think we should add a bit of description, since there is a place for it in the "article" format and the Flux logo doesn't fill the same 4x3 space as the others. Running this by the author to see what text we can put in there before we publish this.

@stefanprodan
Copy link
Member

stefanprodan commented Nov 25, 2024

The article is about migrating existing clusters from Azure PAT or SSH to OIDC. I think the title/description should say this.

@kingdonb
Copy link
Member Author

In this article, I’ll guide you step-by-step through the process of setting up Flux source-controller and image-automation-controller to authenticate against Azure DevOps repositories using OIDC tokens

This sentence from the article I picked is probably too long for the description, and doesn't say exactly what you just said... but combining them, might be the right level of detail - how about this (let's see if it fits in the box):

Migrating existing cluster Git sources and image automations from Azure PAT or SSH to OIDC

@stefanprodan
Copy link
Member

Maybe "Migrating AKS clusters to Azure DevOps OIDC-based auth"

@kingdonb kingdonb marked this pull request as ready for review November 25, 2024 18:39
@kingdonb kingdonb force-pushed the add-azure-oidc-article branch from 8b4fc5e to 9ca1706 Compare November 25, 2024 18:39
@kingdonb kingdonb added area/ecosystem Ecosystem related issues and pull requests area/resources Video resources related issues and pull requests backport:v2-4 To be backported to v2-4 labels Nov 25, 2024
@kingdonb
Copy link
Member Author

This LGTM

@stefanprodan
Copy link
Member

Hmm the description styling looks really bad...

* this description will fit in the space

Signed-off-by: Kingdon Barrett <[email protected]>
@kingdonb kingdonb force-pushed the add-azure-oidc-article branch from 9ca1706 to bc5f53c Compare November 25, 2024 18:44
@kingdonb
Copy link
Member Author

Maybe better if it wasn't center-aligned, I'll tweak it...

@stefanprodan
Copy link
Member

Not center-aligned and maybe a little bit smaller font size

@kingdonb
Copy link
Member Author

Did several iterations on the CSS and template for description in resources, I think this is better 👍

@kingdonb
Copy link
Member Author

Screenshot 2024-11-25 at 3 21 52 PM

Preview ^

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @kingdonb 🥇

@kingdonb kingdonb merged commit 90a0b10 into main Nov 26, 2024
5 checks passed
@kingdonb kingdonb deleted the add-azure-oidc-article branch November 26, 2024 14:24
@fluxcdbot
Copy link
Member

Successfully created backport PR for v2-4:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ecosystem Ecosystem related issues and pull requests area/resources Video resources related issues and pull requests backport:v2-4 To be backported to v2-4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants