-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FluxCD Azure DevOps article resource #2097
Conversation
https://deploy-preview-2097--fluxcd.netlify.app/resources/ I think we should add a bit of description, since there is a place for it in the "article" format and the Flux logo doesn't fill the same 4x3 space as the others. Running this by the author to see what text we can put in there before we publish this. |
The article is about migrating existing clusters from Azure PAT or SSH to OIDC. I think the title/description should say this. |
This sentence from the article I picked is probably too long for the description, and doesn't say exactly what you just said... but combining them, might be the right level of detail - how about this (let's see if it fits in the box):
|
Maybe "Migrating AKS clusters to Azure DevOps OIDC-based auth" |
8b4fc5e
to
9ca1706
Compare
This LGTM |
Hmm the description styling looks really bad... |
* this description will fit in the space Signed-off-by: Kingdon Barrett <[email protected]>
9ca1706
to
bc5f53c
Compare
Maybe better if it wasn't center-aligned, I'll tweak it... |
Not center-aligned and maybe a little bit smaller font size |
Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
Did several iterations on the CSS and template for description in resources, I think this is better 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @kingdonb 🥇
Successfully created backport PR for |
Testing the Resources / Article feature again. (also #2096)
Thanks Mohammed Nour for contributing this article about the new features in Flux 2.4 🎉
(I asked if there was a branding image that goes with this blog, and it was suggested we just use the Flux logo as there isn't one.)