Print readable message on fault code

flxkrmr · Oct 30, 2022 · 6901e9b · 6901e9b
1 parent a6bcae4
commit 6901e9b
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 14 deletions.
diff --git a/lib/fault_code/fault_code_util.c b/lib/fault_code/fault_code_util.c
@@ -2,19 +2,6 @@
 
 
 void createReadableMessage(const char *faultCode, char *messageReadable, unsigned int messageReadableSize) {
-    fault_code_message_t fault_code_messages[] = {
-        (fault_code_message_t) {"111", "All systems work properly"},
-        (fault_code_message_t) {"112", "IAT-sensor: voltage low"},
-        (fault_code_message_t) {"113", "IAT-sensor: voltage high"},
-        (fault_code_message_t) {"114", "IAT-sensor: range"},
-        (fault_code_message_t) {"116", "ECT-sensor: range"},
-        (fault_code_message_t) {"117", "ECT-sensor: voltage low"},
-        (fault_code_message_t) {"118", "ECT-sensor: voltage high"},
-        (fault_code_message_t) {"511", "ECM: ROM error"},
-        (fault_code_message_t) {"512", "ECM: KAM error"},
-        (fault_code_message_t) {"513", "ECM: internal reference voltage"},
-    };
-
     char buffer[40];
 
     for (unsigned int i = 0; i < sizeof(fault_code_messages) / sizeof(fault_code_message_t); i++) {

diff --git a/lib/fault_code/fault_code_util.h b/lib/fault_code/fault_code_util.h
@@ -10,6 +10,19 @@ typedef struct fault_code_message_s
     const char *message;
 } fault_code_message_t;
 
+static fault_code_message_t fault_code_messages[] = {
+    (fault_code_message_t) {"111", "All systems work properly"},
+    (fault_code_message_t) {"112", "IAT-sensor: voltage low"},
+    (fault_code_message_t) {"113", "IAT-sensor: voltage high"},
+    (fault_code_message_t) {"114", "IAT-sensor: range"},
+    (fault_code_message_t) {"116", "ECT-sensor: range"},
+    (fault_code_message_t) {"117", "ECT-sensor: voltage low"},
+    (fault_code_message_t) {"118", "ECT-sensor: voltage high"},
+    (fault_code_message_t) {"511", "ECM: ROM error"},
+    (fault_code_message_t) {"512", "ECM: KAM error"},
+    (fault_code_message_t) {"513", "ECM: internal reference voltage"},
+};
+
 void createReadableMessage(const char *faultCode, char *messageReadable, unsigned int messageReadableSize);
 void splitMessage(const char *message, char *messageLine1, char *messageLine2,
     char *messageLine3, unsigned int messageLinesSize);

diff --git a/src/EecIvReader.cpp b/src/EecIvReader.cpp
@@ -4,6 +4,9 @@
 
 
 #include "EecIv.h"
+extern "C" {
+  #include "fault_code_util.h"
+}
 
 #include <Wire.h>
 
@@ -225,5 +228,9 @@ void onKoeoFinished() {
 
 void onFaultCodeFinished(char message[]) {
   screenMode = RESULT_FAULT_CODE;
-  drawMenuScreen(BACK_SIGN, NO_SIGN, NO_SIGN, "Fault Code", message, "", "");
+  char messageLine1[NUM_COLUMN-1];
+  char messageLine2[NUM_COLUMN-1];
+  char messageLine3[NUM_COLUMN-1];
+  createReadableSplittedMessage(message, messageLine1, messageLine2, messageLine3, NUM_COLUMN - 1);
+  drawMenuScreen(BACK_SIGN, NO_SIGN, NO_SIGN, "Fault Code", messageLine1, messageLine2, messageLine3);
 }