Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong type argument when errors have no columns #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix wrong type argument when errors have no columns #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions flycheck-inline.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,8 @@ ERRORS is a list of `flycheck-error' objects."
(let* ((lines (mapcar 'flycheck-error-line errors))
(line-range (cons (apply 'min lines) (apply 'max lines)))
(columns (mapcar 'flycheck-error-column errors))
(column-range (cons (apply 'min columns) (apply 'max columns))))
(column-range (and (not (seq-some 'null columns))
(cons (apply 'min columns) (apply 'max columns)))))
(mapc #'flycheck-inline-display-error
(seq-filter
(lambda (error)
Expand All @@ -241,8 +242,11 @@ ERRORS is a list of `flycheck-error' objects."
(and
(>= line (car line-range))
(<= line (cdr line-range))
(>= column (car column-range))
(<= column (cdr column-range)))))
(if (and column-range column)
(and
(>= column (car column-range))
(<= column (cdr column-range)))
t))))
(seq-uniq
(seq-mapcat #'flycheck-related-errors errors))))))

Expand Down