Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/flytekit] Smarter copy handling with image spec #3070

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[feature/flytekit] Smarter copy handling with image spec #3070

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef7ca54
feat: add conditions for executing pyflyte-fast-execute.
taieeuu Jan 18, 2025
272b101
Merge branch 'master' into issue_6094
taieeuu Jan 25, 2025
1e42eb9
opt
taieeuu Jan 28, 2025
4f31745
no msg
taieeuu Jan 28, 2025
cf17684
opt
taieeuu Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion flytekit/tools/translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,15 @@ def get_serializable_task(
# ly for certain kinds of tasks. Specifically,
# tasks that rely on user code defined in the container. This should be encapsulated by the auto container
# parent class
container._args = prefix_with_fast_execute(settings, container.args)
if (
(not hasattr(entity, "container_image"))
or (not entity.container_image)
pingsutw marked this conversation as resolved.
Show resolved Hide resolved
or (entity.container_image and not entity.container_image.source_root)
pingsutw marked this conversation as resolved.
Show resolved Hide resolved
):
container._args = prefix_with_fast_execute(settings, container.args)

# elif not entity.container_image.source_root:
# container._args = prefix_with_fast_execute(settings, container.args)

# If the pod spec is not None, we have to get it again, because the one we retrieved above will be incorrect.
# The reason we have to call get_k8s_pod again, instead of just modifying the command in this file, is because
Expand Down
Loading