-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SD+ #44
base: main
Are you sure you want to change the base?
Conversation
To Do Fixes
|
Ok, the events look good now, and I was able to build a plugin with this. The test breakage seems unrelated, how can I help there @fnando? Would love to get this into a new release so I can release the plugin. |
Actually, I found something we may want to improve before releasing. |
With the release of SD+ you now have control over dials and touchscreen on top of the usual buttons. Support adds a few new events received and sent and new configuration objects like Encoder and Layout.
In case of new SD+ plugins, they may be allowed on either a KeyPad or a Dial (via Encoder). Adding this property `keyPad` allows us to disable the options of installing an Action to the KeyPad, forcing it to be Encoder (Dial) only.
Added the handling for Encoder or KeyPad and tested it, it works great, with no BC. |
* @param {DialPressEvent} event The event data. | ||
* @return {void} | ||
*/ | ||
handleDialPress(event: DialPressEvent): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dialPress
is now deprecated in favour of dialDown
and dialUp
I am trying to get this PR to run, and there is some bit rot in the dependencies. For now, I am using these Yarn resolutions added to the "resolutions": {
"string-width": "4.2.3",
"glob": "9.3.5",
"strip-ansi": "6.0.1",
"wrap-ansi": "7.0.0"
} |
With the release of SD+ you now have control over dials and touchscreen on top of the usual buttons. Support adds a few new events received and sent and new configuration objects like Encoder and Layout.
PR Checklist
PR Structure
PRs).
two PRs otherwise).
Thoroughness
fixes.
.md
files, etc… affected by this change.What
Adds support for the new controls available in the SD+
Why
SD+ now has dials and a touch screen to control.
Known limitations
Testing this out in a new plugin before I come back to check if we can improve the experience. Putting this up as a draft so ppl can test it on their own and give any early feedback.