[MIG] auth_user_case_insensitive: mig #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herqs
commented
Mar 24, 2022
Comment on lines
45
to
73
| def test_login_login_is_lowercased(self): | ||
| """It should verify the login is set to lowercase on login""" | ||
| # TODO Write a proper test, that does not use | ||
| # the admin user, but instead uses the one | ||
| # in `_new_record` method. | ||
| res_id = self.model_obj._login( | ||
| self.env.registry.db_name, | ||
| "aDMIn", | ||
| "admin", | ||
| {"interactive": True}, | ||
| ) | ||
| rec_id = self.model_obj.search([("login", "=", "admin")]) | ||
| self.assertEqual( | ||
| rec_id.id, | ||
| res_id, | ||
| "Login with with uppercase chars was not \ | ||
| successful", | ||
| ) |
There was a problem hiding this comment.
Could not make this test work with the fresh user, so I used the default admin credentials.
Link to original tests: https://github.com/OCA/server-auth/blob/fd4947f04ffd8d7d5b4cf63c06a8dea71df40722/auth_user_case_insensitive/tests/test_res_users.py#L48
SButko
reviewed
Mar 24, 2022
…f `_login` * Update code and tests to override `_login` method
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (2 of 2 strings) Translation: server-auth-12.0/server-auth-12.0-auth_user_case_insensitive Translate-URL: https://translation.odoo-community.org/projects/server-auth-12-0/server-auth-12-0-auth_user_case_insensitive/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-13.0/server-auth-13.0-auth_user_case_insensitive Translate-URL: https://translation.odoo-community.org/projects/server-auth-13-0/server-auth-13-0-auth_user_case_insensitive/
Herqs
force-pushed
the
mig/1048-user-case-insensitive-hml
branch
2 times, most recently
from
4b17643 to
d44a4ea
Compare
Herqs
force-pushed
the
mig/1048-user-case-insensitive-hml
branch
from
d44a4ea to
e1f7327
Compare
SButko
reviewed
Apr 7, 2022
auth_user_case_insensitive/hooks.py
Outdated
| users.append(login) | ||
| else: | ||
| raise ValidationError( | ||
| _("Conflicting user logins exist for `%s`") % login |
There was a problem hiding this comment.
Suggested change
| _("Conflicting user logins exist for `%s`") % login | |
| _("Conflicting user logins exist for `%s`", login) |
| #. module: auth_user_case_insensitive | ||
| #: model:ir.model,name:auth_user_case_insensitive.model_res_users | ||
| msgid "Users" | ||
| msgstr "用户" |
There was a problem hiding this comment.
Added lt.po, not sure how great my translation is though, as there is no good translation for the phrase case sensitive.
Herqs
force-pushed
the
mig/1048-user-case-insensitive-hml
branch
from
e1f7327 to
6a01560
Compare
SButko
reviewed
Apr 7, 2022
| #: code:addons/auth_user_case_insensitive/hooks.py:0 | ||
| #, python-format | ||
| msgid "Conflicting user logins exist for `%s`" | ||
| msgstr "Vartotojams `%s` egzistuoja konfliktuojantys prisijungimai" |
There was a problem hiding this comment.
That query checks for uniqueness, no?
Suggested change
| msgstr "Vartotojams `%s` egzistuoja konfliktuojantys prisijungimai" | |
| msgstr "Vartotojo prisijungimo vardas `%s` jau egzistuoja" |
There was a problem hiding this comment.
Sort of, it checks if there are 2 usernames that are identical when lowercased, check happens pre-install
There was a problem hiding this comment.
Changed it to Egzistuoja keli vartotojai su prisijungimu %s``
| #. module: auth_user_case_insensitive | ||
| #: model:ir.model.fields,help:auth_user_case_insensitive.field_res_users__login | ||
| msgid "Used to log into the system. Case insensitive." | ||
| msgstr "Naudojamas prisijungti į sistemą. Nereikšminga ar vesite didžiosiomis ar mažosiomis raidėmis." |
There was a problem hiding this comment.
Suggested change
| msgstr "Naudojamas prisijungti į sistemą. Nereikšminga ar vesite didžiosiomis ar mažosiomis raidėmis." | |
| msgstr "Naudojamas prisijungti į sistemą. Raidžių dydis nesvarbus." |
Herqs
force-pushed
the
mig/1048-user-case-insensitive-hml
branch
from
6a01560 to
c468a99
Compare
SButko
approved these changes
Apr 8, 2022
oerp-odoo
approved these changes
Apr 9, 2022
| partner_id = self.env["res.partner"].create(self.partner_vals) | ||
| self.vals["partner_id"] = partner_id.id | ||
| return self.model_obj.create(self.vals) | ||
|
|
||
| def test_login_is_lowercased_on_create(self): | ||
| """ It should verify the login is set to lowercase on create """ | ||
| """It should verify the login is set to lowercase on create""" |
There was a problem hiding this comment.
So if changing docstring, add period at the end, to make it pydocstyle257 compatible. Also docstring should start with a verb for method. Instead of It should verify, use Verify the login is set..
oerp-odoo
reviewed
Apr 9, 2022
| @@ -20,13 +18,13 @@ def setUp(self): | |||
| self.model_obj = self.env["res.users"] | |||
|
|
|||
| def _new_record(self): | |||
| """ It should enerate a new record to test with """ | |||
| """It should enerate a new record to test with""" | |||
Herqs
force-pushed
the
mig/1048-user-case-insensitive-hml
branch
from
c468a99 to
22c41d7
Compare
Herqs
force-pushed
the
mig/1048-user-case-insensitive-hml
branch
from
22c41d7 to
da63b64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BRANCH] mig/1048-user-case-insensitive-hml
oca/server-auth PR: OCA#361