fix unicorn/no-typeof-undefined todo

fomantic · Dec 4, 2022 · 8f35b33 · 8f35b33
1 parent ffbc3d6
commit 8f35b33
Show file tree

Hide file tree

Showing 26 changed files with 28 additions and 29 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -108,7 +108,6 @@ module.exports = {
         'unicorn/no-console-spaces': 'off',
         'unicorn/no-for-loop': 'off',
         'unicorn/no-hex-escape': 'off',
-        'unicorn/no-typeof-undefined': 'off', // TODO
         'unicorn/no-useless-undefined': 'off', // TODO
         'unicorn/prefer-array-some': 'off',
         'unicorn/prefer-date-now': 'off',

diff --git a/src/definitions/behaviors/api.js b/src/definitions/behaviors/api.js
@@ -18,7 +18,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self
@@ -437,8 +437,8 @@
 
                         if (useFormDataApi) {
                             formData = new FormData($form[0]);
-                            settings.processData = typeof settings.processData !== 'undefined' ? settings.processData : false;
-                            settings.contentType = typeof settings.contentType !== 'undefined' ? settings.contentType : false;
+                            settings.processData = settings.processData !== undefined ? settings.processData : false;
+                            settings.contentType = settings.contentType !== undefined ? settings.contentType : false;
                         } else {
                             let
                                 formArray = $form.serializeArray(),

diff --git a/src/definitions/behaviors/form.js b/src/definitions/behaviors/form.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/behaviors/state.js b/src/definitions/behaviors/state.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/behaviors/visibility.js b/src/definitions/behaviors/visibility.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/globals/site.js b/src/definitions/globals/site.js
@@ -65,13 +65,13 @@
                         module.verbose('Console not available, normalizing events');
                         module.disable.console();
                     }
-                    if (typeof console.group == 'undefined' || typeof console.groupEnd == 'undefined' || typeof console.groupCollapsed == 'undefined') {
+                    if (console.group === undefined || console.groupEnd === undefined || console.groupCollapsed === undefined) {
                         module.verbose('Console group not available, normalizing events');
                         window.console.group = function () {};
                         window.console.groupEnd = function () {};
                         window.console.groupCollapsed = function () {};
                     }
-                    if (typeof console.markTimeline == 'undefined') {
+                    if (console.markTimeline === undefined) {
                         module.verbose('Mark timeline not available, normalizing events');
                         window.console.markTimeline = function () {};
                     }

diff --git a/src/definitions/modules/accordion.js b/src/definitions/modules/accordion.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/modules/calendar.js b/src/definitions/modules/calendar.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/modules/checkbox.js b/src/definitions/modules/checkbox.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/modules/dimmer.js b/src/definitions/modules/dimmer.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/modules/dropdown.js b/src/definitions/modules/dropdown.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/modules/embed.js b/src/definitions/modules/embed.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/modules/flyout.js b/src/definitions/modules/flyout.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/modules/modal.js b/src/definitions/modules/modal.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/modules/nag.js b/src/definitions/modules/nag.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/modules/popup.js b/src/definitions/modules/popup.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/modules/progress.js b/src/definitions/modules/progress.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/modules/rating.js b/src/definitions/modules/rating.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/modules/search.js b/src/definitions/modules/search.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/modules/shape.js b/src/definitions/modules/shape.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/modules/sidebar.js b/src/definitions/modules/sidebar.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/modules/slider.js b/src/definitions/modules/slider.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/modules/sticky.js b/src/definitions/modules/sticky.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/modules/tab.js b/src/definitions/modules/tab.js
@@ -18,7 +18,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/modules/toast.js b/src/definitions/modules/toast.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self

diff --git a/src/definitions/modules/transition.js b/src/definitions/modules/transition.js
@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math == Math)
         ? window
         : (typeof self != 'undefined' && self.Math == Math)
             ? self