-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lint): remove unneeded parentheses around expressions #2589
Conversation
9b3bb31
to
e33883c
Compare
264b8f4
to
d6d39e9
Compare
121a624
to
9e067d8
Compare
d4c96bf
to
637b0b0
Compare
2ba232e
to
db7fe39
Compare
db7fe39
to
1ded5c4
Compare
1ded5c4
to
55250c8
Compare
@lubber-de fixing stylelint for upper case colors can be done easily with so I prefer to stay with the default LC for LESS/CSS colors and UC for escapes in JS. Unified LC is not (easily) possible, as Unicorn has no configuration for it. Also UC for escapes in the only option with PHP CS Fixer, so it seems to be well accepted casing. So if ok with you, I prefer too keep the casing rules as they are (and as default by the recommended CS AirBnb/Unicorn/Stylelint configs). |
This reverts commit 4f7f0b2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Modernize code using eslint advisory introduced in GH-2596. This PR focuses on fixing
no-extra-parens
rule with a help or a custom rule output filter.